[MASSEMBLY-970] Deduplicate artifact filter patterns - #121
Open
wilx wants to merge 1 commit into
Open
Conversation
Duplicate input strings were compiled into distinct Pattern instances. Matching one instance therefore left equivalent duplicates untriggered and caused strict downstream filters to fail. Fixes apache/maven-assembly-plugin#1178
wilx
marked this pull request as ready for review
July 27, 2026 20:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deduplicate identical artifact-filter criteria before compiling them into internal pattern objects.
Each occurrence was previously compiled into a distinct object whose equality is identity-based. Matching stops after the first matching pattern, so an identical second object remained untriggered. In Maven Assembly Plugin this produced a false "patterns were never triggered" warning and caused assemblies using strict filtering to fail.
The regression test exercises both inclusion and exclusion filters through their shared statistics-reporting contract.
Fixes apache/maven-assembly-plugin#1178
Validation
JAVA_HOME=/opt/jdks/latest-8 /opt/maven/apache-maven-3.6.3/bin/mvn -DminimalMavenBuildVersion=3.6.3 clean verify -eJAVA_HOME=/opt/jdks/latest-21 /opt/maven/latest/bin/mvn clean verify -eJAVA_HOME=/opt/jdks/latest-21 /opt/maven/latest-4/bin/mvn clean verify -e3.8.1-SNAPSHOTand this patched library, using both normal and strict filtering under Maven 3.9.16 and Maven 4.0.0-rc-5. All four builds passed without the false warning, and each archive contained the expected single Jython JAR.Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).This repository does not define a
run-itsprofile; the downstream Assembly reproducer was run directly as described above.If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.