Handle plain MavenProject reference in AttachArtifactTask (#375) - #382
Open
elharo wants to merge 1 commit into
Open
Handle plain MavenProject reference in AttachArtifactTask (#375)#382elharo wants to merge 1 commit into
elharo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #375
Summary
AttachArtifactTaskcast the reference resolved frommavenProjectRefIdtoMavenAntRunProjectunconditionally. When the attribute pointed at a plainMavenProjectreference (e.g.maven.project, whichAntRunMojoalso registers), the task threw a rawClassCastException.Changes
AttachArtifactTask.java: resolve the Maven project by type. AMavenAntRunProjectreference is unwrapped, aMavenProjectreference is used directly, and any other type is rejected with a clearBuildExceptioninstead of aClassCastException.AttachArtifactTaskTestcovering:mavenProjectRefIdpointing at a plainMavenProject(previouslyClassCastException),MavenAntRunProjectwrapper keeps working,BuildException.Verification
ClassCastException) and pass with the fix.mvn verify(rat, checkstyle, spotless, unit tests, javadoc) passes.mvn verify -Prun-itspasses: all 29 integration tests succeed.