Honor the mavenProjectId attribute in DependencyFilesetsTask (#371) - #378
Open
elharo wants to merge 2 commits into
Open
Honor the mavenProjectId attribute in DependencyFilesetsTask (#371)#378elharo wants to merge 2 commits into
elharo wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #371
Summary
DependencyFilesetsTaskignored themavenProjectIdattribute: the existence check used the configurable field, but the project lookup used a hardcoded"maven.project"reference. SettingmavenProjectIdto anything other than the default was silently ignored, and invoking the task standalone (without themaven.projectreference registered byAntRunMojo) threw an NPE.Changes
DependencyFilesetsTask.java: look up theMavenProjectvia the configuredmavenProjectIdreference instead of the hardcoded"maven.project"string.DependencyFilesetsTaskTestwith two cases:honorsConfiguredMavenProjectId— when both the default and a custom project reference exist, the custom one is used.worksWithoutDefaultMavenProjectReference— the task works standalone with a custommavenProjectId, instead of throwing an NPE.Verification
mvn verify(rat, checkstyle, spotless, unit tests, javadoc) passes.mvn verify -Prun-itspasses: all 29 integration tests succeed.