Skip dependencies without a resolved artifact file when setting properties (#372) - #377
Open
elharo wants to merge 1 commit into
Open
Skip dependencies without a resolved artifact file when setting properties (#372)#377elharo wants to merge 1 commit into
elharo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
#372
Summary
AntRunMojo.copyPropertiescalledartifact.getFile().getPath()without a null check, throwing an NPE when a project dependency has no resolved artifact file (e.g. a dependency that failed to resolve or a project-level dependency in a reactor build). Such dependencies are now skipped with a warning instead of failing the build, matching the expected behavior described in the issue (and mirroring the existing null handling ingetPathFromArtifacts).Changes
AntRunMojo.java: null-check the artifact file incopyProperties; if missing, log a warning and skip that property.AntRunMojoCopyPropertiesTestreproducing the NPE (fails on master, passes with the fix).Verification
NullPointerException: Cannot invoke "java.io.File.getPath()"), passes with the fix.mvn verify(rat, checkstyle, spotless, unit tests, javadoc) passes.mvn verify -Prun-itspasses: all 29 integration tests succeed.