Skip to content

fix(bitbucket): normalize issue comment deleted flag #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinmclean merged 1 commit into from
Jul 19, 2026
Merged

fix(bitbucket): normalize issue comment deleted flag #895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/bitbucket/src/magpie_bitbucket/normalize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,7 +1056,7 @@ def _cloud_issue_comment(raw: dict[str, Any]) -> dict[str, Any]:
"updated": _cloud_timestamp(raw.get("updated_on")),
"date": _cloud_timestamp(raw.get("created_on")),
"kind": "comment",
"deleted": raw.get("deleted"),
"deleted": _bool_or_none(raw.get("deleted")),
"permalink": _cloud_link(raw, "html"),
"raw": raw,
}
Expand Down
6 changes: 6 additions & 0 deletions tools/bitbucket/tests/test_bitbucket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2213,6 +2213,12 @@ def test_normalize_cloud_issue_comments() -> None:
assert normalized["comments"][0]["kind"] == "comment"
assert normalized["comments"][0]["deleted"] is False

deleted_normalized = issue_comments(
"cloud",
{"issue_id": "7", "values": [{"id": 102, "deleted": True}]},
)
assert deleted_normalized["comments"][0]["deleted"] is True


@patch("magpie_bitbucket.cloud.get_issue_comments")
def test_cli_issue_comments_cloud(
Expand Down