Smarter use of sort-field optimizations in DV range queries - #16424
Open
romseygeek wants to merge 3 commits into
Open
Smarter use of sort-field optimizations in DV range queries#16424romseygeek wants to merge 3 commits into
romseygeek wants to merge 3 commits into
Conversation
When the primary sort field on a segment contains no values or only a single value, then it is effectively a no-op and range queries against the secondary sort field can make use of the sort-field optimizations usually reserved for queries against the primary. This adds a helper method, Sort.getPrimarySortField(LeafReader), that tries to identify no-op primary sort fields using index-level stats from FieldInfo or associated DocValuesSkipper entries, and uses it in the various XDocValuesRangeQuery implementations.
Contributor
Author
|
We can also use this in TopFieldCollector, but that's slightly more complex so I'd like to leave it for a follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the primary sort field on a segment contains no values or only a single value, then it is effectively a no-op and range queries against the secondary sort field can make use of the sort-field optimizations usually reserved for queries against the primary.
This adds a helper method, Sort.getPrimarySortField(LeafReader), that tries to identify no-op primary sort fields using index-level stats from FieldInfo or associated DocValuesSkipper entries, and uses it in the various XDocValuesRangeQuery implementations.