Skip to content

Avoid redundant addresses.get() in sorted numeric rangeIntoBitSet #16399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgup432 wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −1
Open

Avoid redundant addresses.get() in sorted numeric rangeIntoBitSet #16399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b842452
Avoid redundant addresses.get() in sorted numeric rangeIntoBitSet
sgup432 Jul 16, 2026
5c5557b
Add changelog
sgup432 Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lucene/CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,8 @@ Optimizations
* GITHUB#16380: Speed up filtered disjunction queries when the filter is part of the
index sort by advancing the filter before calculating impacts. (Alan Woodward)

* GITHUB#16399: Reuse the previous end offset to skip a redundant addresses.get() in sorted numeric rangeIntoBitSet. (Sagar Upadhyaya)

Bug Fixes
---------------------
* GITHUB#16350: Disable bulk-scoring in monitor queries. (Alan Woodward)
Expand Down
3 changes: 2 additions & 1 deletion lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90DocValuesProducer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2041,12 +2041,13 @@ public void rangeIntoBitSet(
v, fromDoc, endDoc, cardinality, lo, hi, bitSet, offset);
return;
}
long startOffset = addresses.get(fromDoc);
for (int currentDoc = fromDoc; currentDoc < endDoc; currentDoc++) {
long startOffset = addresses.get(currentDoc);
long endOffset = addresses.get(currentDoc + 1L);
if (sortedNumericMatchesRange(v, startOffset, endOffset, lo, hi)) {
bitSet.set(currentDoc - offset);
}
startOffset = endOffset;
}
}

Expand Down
Loading