Fix double-counting of Automaton in AutomatonQuery#ramBytesUsed - #16390
Merged
mikemccand merged 1 commit intoJul 14, 2026
Merged
Conversation
Sasilekha
force-pushed
the
fix/16389-automaton-query-rambytes-double-count
branch
3 times, most recently
from
July 14, 2026 09:30
5a463ac to
002e141
Compare
Sasilekha
force-pushed
the
fix/16389-automaton-query-rambytes-double-count
branch
from
July 14, 2026 09:39
002e141 to
58727c0
Compare
Sasilekha
marked this pull request as ready for review
July 14, 2026 12:12
mikemccand
approved these changes
Jul 14, 2026
mikemccand
left a comment
mikemccand
left a comment
Member
There was a problem hiding this comment.
Looks great, and nice catch -- thanks @Sasilekha . I'll merge and backport.
mikemccand
pushed a commit
that referenced
this pull request
Jul 14, 2026
Member
|
Thanks @Sasilekha -- I also backported to 10.6.0, and moved the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #16389.
AutomatonQuery#ramBytesUsed() double-counts the underlying Automaton when isBinary=true CompiledAutomaton already accounts for it via runAutomaton/nfaRunAutomaton, but the outer query added automaton.ramBytesUsed() on top.
Fix adds CompiledAutomaton#sharesAutomaton(Automaton) to detect when the same instance is held internally, and skips the outer contribution in that case.