Remove IOException from LeafReader.getDocValuesSkipper() - #16388
Merged
Conversation
All of the global metadata available without calling advance() on a skipper is loaded at Skipper creation time and can therefore be returned without doing any IO. The only reason we need to do IO to create a Skipper is slicing an IndexInput, and that can be done lazily in advance() as skippers are designed to only be consumed in a single thread. This removes the throws declaration from LeafReader.getDocValuesSkipper(), which in combination with a similar change on PointValues will make numeric field metadata available without IO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of the global metadata available without calling advance() on a skipper is loaded at Skipper creation time and can therefore be returned without doing any IO. The only reason we need to do IO to create a Skipper is slicing an IndexInput, and that can be done lazily in advance() as skippers are designed to only be consumed in a single thread. This removes the throws declaration from LeafReader.getDocValuesSkipper(), which in combination with a similar change on PointValues will make numeric field metadata available without IO.