used WANDScorer.advanceShallow() to enable block-max optimizations when nested in conjunctions - #16220
Conversation
| for (Scorer scorer : allScorers) { | ||
| if (scorer.docID() < target) { | ||
| scorer.advanceShallow(target); | ||
| if (scorer.docID() <= target) { |
There was a problem hiding this comment.
Nit: the old code used < target (skip propagation when already at target), this uses <= target. The <= is correct here since you need the return value from advanceShallow even when docID() == target, but worth a one-line comment explaining the change from < to <= (vs a typo).
| if (scorer.docID() <= target) { | ||
| newUpTo = Math.min(newUpTo, scorer.advanceShallow(target)); | ||
| } else if (scorer.docID() != DocIdSetIterator.NO_MORE_DOCS) { | ||
| newUpTo = Math.min(newUpTo, scorer.docID() - 1); |
There was a problem hiding this comment.
Consider return (target <= upTo) ? Math.min(upTo, newUpTo) : newUpTo;
Otherwise the early return discards the freshly computed newUpTo, which could be tighter than upTo.
Always returning the previous upTo is safe (advanceShallow contract allows over-approximation), but it means the parent gets a looser bound than necessary hence the suggested conditional.
d494ad6 to
a09f3be
Compare
github-actions
Bot
added
module:core/store
module:analysis
module:core/index
module:demo
module:highlighter
module:benchmark
module:suggest
module:spatial
module:luke
module:core/codecs
module:facet
module:grouping
module:core/FSTs
module:queryparser
module:join
module:classification
module:test-framework
module:replicator
module:expressions
module:sandbox
module:spatial3d
module:misc
module:queries
module:monitor
labels
fc65e6e to
3175d3f
Compare
|
moved entry of changes.txt under 10.6 |
…ns when nested in conjunctions
3175d3f to
ccdec7d
Compare
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
|
LGTM, thanks for working on this! Nice to have nested WAND skip blocks instead of treating the whole segment as one. Will merge soon. |
|
Merged and backported to 10x, thanks @iprithv ! |
4 participants
used WANDScorer.advanceShallow() so that WAND queries nested inside conjunctions can skip blocks instead of treating the entire segment as one giant block.