-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add hadamard rotation to vector fields #16092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shubhamvishu
wants to merge
19
commits into
apache:main
Choose a base branch
from
shubhamvishu:rotation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
cb9e125
Add RotationPreconditionedVectorsFormat to sandbox
shubhamvishu dec4950
Move rotation preconditioning from sandbox wrapper into OSQ
shubhamvishu e8ea930
Introduce Lucene105 scalar-quantized codec with rotation preconditioning
shubhamvishu 69ec702
Dont bump codec
shubhamvishu e61e258
Add flag to enable rotation
shubhamvishu 5901d6a
Set flag to always true
1a3b59d
Fix rotation space mismatch for 1-bit and 2-bit asymmetric scoring du…
28a9f68
Fix gradle test issues
2106077
Enable rotation to luceneutil benchmarks
2fdc47e
Revert "Enable rotation to luceneutil benchmarks"
22d6ec3
Move query rotation to KnnFloatVeectorQuery and maintain rotation per…
8bdc0cd
Fix missing scorer/rescorer in InverseRotatedFloatVectorValues
ada1837
Introduce RotationAwareKnnVectorsFormat as a format-agnostic rotation…
4ca87ce
Merge branch 'main' into rotation
e89d636
Update the query inplace
4c22bc4
Add jmh benchy HadamardRotationBenchmark
5eda738
Make rotation per segment and register RotationAwareKnnVectorsFormat …
5f2f6ca
Add TestRotationAwareKnnVectorsFormat for rotation format
ff81d81
Persist delegate format name so rotation indices read correctly via SPI
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
76 changes: 76 additions & 0 deletions
76
lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/HadamardRotationBenchmark.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.lucene.benchmark.jmh; | ||
|
|
||
| import java.util.concurrent.ThreadLocalRandom; | ||
| import java.util.concurrent.TimeUnit; | ||
| import org.apache.lucene.util.quantization.HadamardRotation; | ||
| import org.openjdk.jmh.annotations.Benchmark; | ||
| import org.openjdk.jmh.annotations.BenchmarkMode; | ||
| import org.openjdk.jmh.annotations.Fork; | ||
| import org.openjdk.jmh.annotations.Level; | ||
| import org.openjdk.jmh.annotations.Measurement; | ||
| import org.openjdk.jmh.annotations.Mode; | ||
| import org.openjdk.jmh.annotations.OutputTimeUnit; | ||
| import org.openjdk.jmh.annotations.Param; | ||
| import org.openjdk.jmh.annotations.Scope; | ||
| import org.openjdk.jmh.annotations.Setup; | ||
| import org.openjdk.jmh.annotations.State; | ||
| import org.openjdk.jmh.annotations.Warmup; | ||
|
|
||
| @BenchmarkMode(Mode.Throughput) | ||
| @OutputTimeUnit(TimeUnit.MICROSECONDS) | ||
| @State(Scope.Benchmark) | ||
| @Warmup(iterations = 4, time = 1) | ||
| @Measurement(iterations = 5, time = 1) | ||
| @Fork( | ||
| value = 3, | ||
| jvmArgsAppend = {"-Xmx2g", "-Xms2g", "-XX:+AlwaysPreTouch"}) | ||
| public class HadamardRotationBenchmark { | ||
|
|
||
| @Param({"1", "128", "207", "256", "300", "512", "702", "1024"}) | ||
| int size; | ||
|
|
||
| private float[] input; | ||
| private float[] output; | ||
| private float[] scratch; | ||
| private HadamardRotation rotation; | ||
|
|
||
| @Setup(Level.Iteration) | ||
| public void init() { | ||
| ThreadLocalRandom random = ThreadLocalRandom.current(); | ||
| input = new float[size]; | ||
| output = new float[size]; | ||
| scratch = new float[size]; | ||
| for (int i = 0; i < size; i++) { | ||
| input[i] = random.nextFloat() * 2 - 1; | ||
| } | ||
| rotation = HadamardRotation.forDimension(size); | ||
| } | ||
|
|
||
| @Benchmark | ||
| public float[] rotate() { | ||
| rotation.rotate(input, output); | ||
| return output; | ||
| } | ||
|
|
||
| @Benchmark | ||
| public float[] inverseRotate() { | ||
| rotation.inverseRotate(input, output, scratch); | ||
| return output; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about
RotatingWrapperKnnVectorsFormat? Or maybe justRotatingKnnVectorsFormat?