Change access modifier for readAdvise in MMapDirectory

[navneet1v]

Description

Change access modifier for readAdvise in MMapDirectory. Made the access modifier protected so that classes which overrides MMapDirectory can use the readAdvise or if needed expose them.

I considered adding a getter for this parameter too, but went against it since the return type is pretty weird. I am open to adding a getting too. If we are happy with a getter like this:

public BiFunction<String, IOContext, Optional<ReadAdvice>> getReadAdvise() {
  return readAdvice;
}

or we can also expose a function like

public ReadAdvice getReadAdviseForFile(String filename, IOContext ioContext) {
    return readAdvice.apply(filename, ioContext);
}

This will ensure that consumers can validate if readAdvise is correctly set or not.

[navneet1v]

Will set change log soon

[github-actions]

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

[navneet1v]

@vigyasharma , @benwtrent , @jainankitk can anyone of you take a look at this PR?

[github-actions]

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

[ChrisHegarty]

Can you please explain a little more why would want to make this change? (what use case you’re trying to solve)

[github-actions]

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

[github-actions]

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!