Skip to content

Set minimum competitive score in FirstPassGroupingCollector - #15494

Open
gaobinlong wants to merge 7 commits into
apache:mainfrom
gaobinlong:setMinScore
Open

Set minimum competitive score in FirstPassGroupingCollector#15494
gaobinlong wants to merge 7 commits into
apache:mainfrom
gaobinlong:setMinScore

Conversation

@gaobinlong

Copy link
Copy Markdown
Contributor

Similar to TopScoreDocCollector, in FirstPassGroupingCollector, if the primary sort is _score, we can propagate the minimum competitive score to the scorer when the orderedGroups is full, this can improve the grouping performance by 20%, below are the benchmark result:

query DSL in OpenSearch:

GET big5/_search
{
  "query": {
    "match": {
      "message": "50-136-239-27"
    }
  },
  "collapse": {
    "field": "host.name"
  }
}

test result:

Before:
|                                   50th percentile service time | collapsing |     426.714 |     ms |
|                                   90th percentile service time | collapsing |     438.719 |     ms |
|                                   99th percentile service time | collapsing |     465.926 |     ms |
|                                 99.9th percentile service time | collapsing |     496.134 |     ms |
|                                  100th percentile service time | collapsing |     515.556 |     ms |

After:
|                                   50th percentile service time | collapsing |     353.501 |     ms |
|                                   90th percentile service time | collapsing |     358.511 |     ms |
|                                   99th percentile service time | collapsing |     379.314 |     ms |
|                                 99.9th percentile service time | collapsing |      398.28 |     ms |
|                                  100th percentile service time | collapsing |     476.743 |     ms |

Related to #15178.

Signed-off-by: Binlong Gao <gbinlong@amazon.com>
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
@github-actions github-actions Bot added this to the 10.4.0 milestone Dec 10, 2025
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
@github-actions

Copy link
Copy Markdown
Contributor

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

Signed-off-by: Binlong Gao <gbinlong@amazon.com>
@github-actions

Copy link
Copy Markdown
Contributor

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

@github-actions github-actions Bot added the Stale label Jan 10, 2026
@benwtrent benwtrent modified the milestones: 10.4.0, 10.5.0 Feb 6, 2026
@github-actions github-actions Bot removed the Stale label Feb 7, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

@github-actions github-actions Bot added the Stale label Feb 21, 2026
@gaobinlong

Copy link
Copy Markdown
Contributor Author

@jpountz @mikemccand mind taking look into this PR? Thanks!

@github-actions github-actions Bot removed the Stale label Mar 25, 2026
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

@github-actions github-actions Bot added the Stale label Apr 8, 2026
@romseygeek romseygeek modified the milestones: 10.5.0, 10.6.0 Jun 26, 2026
@github-actions github-actions Bot removed the Stale label Jun 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

@github-actions github-actions Bot added the Stale label Jul 12, 2026
Signed-off-by: Binlong Gao <gbinlong@amazon.com>
@gaobinlong

Copy link
Copy Markdown
Contributor Author

@javanna , could you help to review this PR? Thanks!

@github-actions github-actions Bot removed the Stale label Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants