Skip to content

Null exception occured when click on Luke desktop browser button - #14880

Merged
dweiss merged 7 commits into
apache:mainfrom
wuth:main
Jul 3, 2025
Merged

Null exception occured when click on Luke desktop browser button#14880
dweiss merged 7 commits into
apache:mainfrom
wuth:main

Conversation

@wuth

@wuth wuth commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Null exception occured when click on Luke desktop browser button
[/issues/13345]

Description

Null exception occured when click on Luke desktop browser button
apache#13345
@github-actions

github-actions Bot commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

Comment on lines +296 to +300
if(path.getParent() != null) {
return path.getParent().toAbsolutePath().toFile();
}else {
return path.toAbsolutePath().toFile();
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run ./gradlew tidy to clean up code formatting. When is this situation possible, by the way (a file without a parent directory)?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry ,I am a newer for github. And I just commit the code which I had tested last year. So I have no local develop environment. How can I Run ./gradlew tidy to clean up code formatting? This situation occured when I open a directory from another window pc by share folder.

@wuth
wuth requested a review from dweiss July 1, 2025 18:46

@dweiss dweiss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comment.

@github-actions

github-actions Bot commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

@github-actions

github-actions Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

@github-actions

github-actions Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

checkGoogleJavaFormat
@github-actions

github-actions Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

@github-actions

github-actions Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

@wuth
wuth requested a review from dweiss July 2, 2025 05:31
@dweiss

dweiss commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

It's all explained here -
https://github.com/apache/lucene/blob/main/CONTRIBUTING.md

but I see you've managed to fix it, great. I am still curious how you managed to hit that code corner - will give it a try in a spare moment using windows shares.

@wuth

wuth commented Jul 3, 2025

Copy link
Copy Markdown
Contributor Author

It's all explained here - https://github.com/apache/lucene/blob/main/CONTRIBUTING.md

but I see you've managed to fix it, great. I am still curious how you managed to hit that code corner - will give it a try in a spare moment using windows shares.

Yes, I test to run ./gradlew tidy by adding a workflow yml directely on github web, but it didn't work. Then I fixed the code formatting manually. About this bug, at that time, I was short of local disk space, so I utilized the shared directory.

reproduce this problem :
1.Clear the content in .luke.d/history
2.Double click lucene-x.x.x\luke\luke.bat
3.Select an share folder like as \xxx.xxx.x.x\luceneDataFolder
Then you would find you can not select another luceneDataFolder, nothing response on the select button being clicked.

@github-actions

github-actions Bot commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

@dweiss dweiss added this to the 10.3.0 milestone Jul 3, 2025
@dweiss
dweiss merged commit 5827c15 into apache:main Jul 3, 2025
8 checks passed
@dweiss

dweiss commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

Thank you. I could reproduce the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants