Fix intermittent failure of TestDoubleValuesSourceRescorer - #14793
Merged
vigyasharma merged 2 commits intoJun 16, 2025
Conversation
Contributor
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
vigyasharma
approved these changes
Jun 16, 2025
vigyasharma
left a comment
Contributor
There was a problem hiding this comment.
Oops, Thanks for fixing this Chris!
vigyasharma
pushed a commit
that referenced
this pull request
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an intermittent failure of TestDoubleValuesSourceRescorer, where the test sometimes randomly selects too few documents to index leading to no matches in the search. Failure example:
I think that bumping the number of docs to index should be sufficient, as I see no failures even after several hundreds of thousands runs.
relates #14776