Skip to content

Fix intermittent failure of TestDoubleValuesSourceRescorer - #14793

Merged
vigyasharma merged 2 commits into
apache:mainfrom
ChrisHegarty:fix_TestDoubleValuesSourceRescorer
Jun 16, 2025
Merged

Fix intermittent failure of TestDoubleValuesSourceRescorer#14793
vigyasharma merged 2 commits into
apache:mainfrom
ChrisHegarty:fix_TestDoubleValuesSourceRescorer

Conversation

@ChrisHegarty

Copy link
Copy Markdown
Contributor

This commit fixes an intermittent failure of TestDoubleValuesSourceRescorer, where the test sometimes randomly selects too few documents to index leading to no matches in the search. Failure example:

org.apache.lucene.search.TestDoubleValuesSourceRescorer > test suite's output saved to /../lucene/core/build/test-results/test/outputs/OUTPUT-org.apache.lucene.search.TestDoubleValuesSourceRescorer.txt, copied below:
   >     java.lang.ArrayIndexOutOfBoundsException: Index 0 out of bounds for length 0
   >         at __randomizedtesting.SeedInfo.seed([86E2E915B8727B0:A3943384845BA19E]:0)
   >         at org.apache.lucene.search.TestDoubleValuesSourceRescorer.testBasic(TestDoubleValuesSourceRescorer.java:99)
   >         at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
   >         at java.base/java.lang.reflect.Method.invoke(Method.java:580)
...

I think that bumping the number of docs to index should be sufficient, as I see no failures even after several hundreds of thousands runs.

relates #14776

@github-actions

Copy link
Copy Markdown
Contributor

This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.

@ChrisHegarty ChrisHegarty added the skip-changelog Apply to PRs that don't need a changelog entry, stopping the automated changelog check. label Jun 16, 2025

@vigyasharma vigyasharma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, Thanks for fixing this Chris!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:core/search skip-changelog Apply to PRs that don't need a changelog entry, stopping the automated changelog check. type:test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants