Skip to content

[LIVY-649] Use HTTP method DELETE instead of POST for statement cancellation API#211

Open
o-shevchenko wants to merge 2 commits into
apache:masterfrom
o-shevchenko:LIVY-649
Open

[LIVY-649] Use HTTP method DELETE instead of POST for statement cancellation API#211
o-shevchenko wants to merge 2 commits into
apache:masterfrom
o-shevchenko:LIVY-649

Conversation

@o-shevchenko

@o-shevchenko o-shevchenko commented Aug 23, 2019

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Unify Livy REST API to use more common DELETE method instead of POST for statement cancellation API.
Before:
POST /sessions/{sessionId}/statements/{statementId}/cancel
After:
DELETE /sessions/{sessionId}/statements/{statementId}

https://issues.apache.org/jira/browse/LIVY-649

How was this patch tested?

unit tests
manual verification:
image

@o-shevchenko o-shevchenko changed the title [LIVY-649] Change HTTP method for statement cancellation from POST to DELETE [LIVY-649] Use HTTP method POST instead of DELETE for statement cancellation API Aug 23, 2019
@o-shevchenko o-shevchenko changed the title [LIVY-649] Use HTTP method POST instead of DELETE for statement cancellation API [LIVY-649] Use HTTP method DELETE instead of POST for statement cancellation API Aug 23, 2019
@codecov-io

codecov-io commented Aug 24, 2019

Copy link
Copy Markdown

Codecov Report

Merging #211 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #211      +/-   ##
============================================
+ Coverage     68.52%   68.75%   +0.22%     
  Complexity      913      913              
============================================
  Files           100      100              
  Lines          5696     5696              
  Branches        862      862              
============================================
+ Hits           3903     3916      +13     
+ Misses         1233     1220      -13     
  Partials        560      560
Impacted Files Coverage Δ Complexity Δ
...server/interactive/InteractiveSessionServlet.scala 67.71% <100%> (ø) 6 <0> (ø) ⬇️
...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala 52.94% <0%> (-2.95%) 7% <0%> (ø)
...scala/org/apache/livy/repl/SparkRInterpreter.scala 60.69% <0%> (+0.57%) 14% <0%> (ø) ⬇️
...ain/java/org/apache/livy/rsc/driver/RSCDriver.java 78.81% <0%> (+0.84%) 41% <0%> (ø) ⬇️
...cala/org/apache/livy/repl/ProcessInterpreter.scala 59.52% <0%> (+2.38%) 6% <0%> (ø) ⬇️
.../scala/org/apache/livy/sessions/SessionState.scala 61.11% <0%> (+2.77%) 2% <0%> (ø) ⬇️
...ain/scala/org/apache/livy/utils/SparkYarnApp.scala 79.57% <0%> (+6.33%) 33% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a4d0f1...fe14f29. Read the comment docs.

@yiheng

yiheng commented Aug 24, 2019

Copy link
Copy Markdown
Contributor

Maybe we need to consider the API compatibility with the old version.

@jerryshao

Copy link
Copy Markdown
Contributor

Yes, agree with @yiheng , this will simply break the compatibility, I would not change this unless we have a sufficient reason.

@o-shevchenko

Copy link
Copy Markdown
Contributor Author

Can it be a part of some major release?

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (9a4d0f1) to head (fe14f29).
Report is 99 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #211      +/-   ##
============================================
+ Coverage     68.52%   68.75%   +0.22%     
  Complexity      913      913              
============================================
  Files           100      100              
  Lines          5696     5696              
  Branches        862      862              
============================================
+ Hits           3903     3916      +13     
+ Misses         1233     1220      -13     
  Partials        560      560              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has had no activity for at least 3 months. If you are still working on this change or plan to move it forward, please leave a comment or push a new commit so we know to keep it open. Otherwise, this PR will be closed automatically in about one month. Thank you for your contribution to Apache Livy!

@github-actions github-actions Bot added the stale label Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants