[LIVY-649] Use HTTP method DELETE instead of POST for statement cancellation API#211
[LIVY-649] Use HTTP method DELETE instead of POST for statement cancellation API#211o-shevchenko wants to merge 2 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
============================================
+ Coverage 68.52% 68.75% +0.22%
Complexity 913 913
============================================
Files 100 100
Lines 5696 5696
Branches 862 862
============================================
+ Hits 3903 3916 +13
+ Misses 1233 1220 -13
Partials 560 560
Continue to review full report at Codecov.
|
|
Maybe we need to consider the API compatibility with the old version. |
|
Yes, agree with @yiheng , this will simply break the compatibility, I would not change this unless we have a sufficient reason. |
|
Can it be a part of some major release? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
============================================
+ Coverage 68.52% 68.75% +0.22%
Complexity 913 913
============================================
Files 100 100
Lines 5696 5696
Branches 862 862
============================================
+ Hits 3903 3916 +13
+ Misses 1233 1220 -13
Partials 560 560 ☔ View full report in Codecov by Sentry. |
|
This pull request has been automatically marked as stale because it has had no activity for at least 3 months. If you are still working on this change or plan to move it forward, please leave a comment or push a new commit so we know to keep it open. Otherwise, this PR will be closed automatically in about one month. Thank you for your contribution to Apache Livy! |
What changes were proposed in this pull request?
Unify Livy REST API to use more common DELETE method instead of POST for statement cancellation API.
Before:
POST /sessions/{sessionId}/statements/{statementId}/cancel
After:
DELETE /sessions/{sessionId}/statements/{statementId}
https://issues.apache.org/jira/browse/LIVY-649
How was this patch tested?
unit tests

manual verification: