KNOX-3321 - KnoxToken Support for RFC 8693 Token Exchange act Claim#1229
Merged
Conversation
Test Results21 tests 21 ✅ 1s ⏱️ Results for commit da344ec. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3321 - KnoxToken Support for RFC 8693 Token Exchange act Claim
What changes were proposed in this pull request?
To support use cases that need insight into access of a resource on behalf of user other than the token holder, we need to add the 'act' chain claim. The ability track a chain of interactions being done by services, pipelines or agents will allow for better audit detail and authorization decision making.
Based on the existence of the ImpersonatedPrincipal in the Java Subject, KnoxToken API will add the 'act' claim with a nested 'sub' to represent the entity acting on behalf of the primary 'sub' of the token.
This requires adding additional methods to our JWTTokeService for both adding the 'act' claim itself but also for extracting it from a parsed token.
How was this patch tested?
All existing unit and integration tests were built and rain locally and new test cases were added and also run.