analyze-action-pr: document gh keyring and docker PATH gotchas - #1135
Open
potiuk wants to merge 1 commit into
Open
analyze-action-pr: document gh keyring and docker PATH gotchas#1135potiuk wants to merge 1 commit into
potiuk wants to merge 1 commit into
Conversation
Both failures point away from their cause. A keyring-stored gh token is unreachable from the child process verify_action_build spawns, so the nested `gh pr diff` 401s and the CLI reports "could not fetch diff" even though `gh auth status` is healthy. Docker Desktop's CLI lives in ~/.docker/bin, which may be off PATH, so "docker is required but not found" fires while the daemon is running. Also records the #1133/#1134 precedent: a tag-pinned-base-image warning that the already-approved version shares is not a regression. Generated-by: Claude Opus 5 (1M context) via Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the #1133 / #1134 triage. Two environment failures in
verify_action_buildreport causes that point away from the real problem, andboth cost a diagnosis round-trip:
ghtoken is unreachable from the child process the CLIspawns, so the nested
gh pr diffgets HTTP 401 and the CLI printscould not fetch diff for PR #<N>even thoughgh auth statusreports ahealthy login.
~/.docker/bin, which may be offPATH(or a sandbox-denied read path), so
docker is required but not found in PATHfires while the daemon is running fine.Adds to the
analyze-action-prskill:and fix for each, plus the one-line test that identifies the keyring case
(
bash -c 'gh auth status'fails while a directgh auth statussucceeds).FROMwarning is already present on the approved version, it is a standing
property of the action rather than a regression the bump introduced.
Docs-only; no code touched.
prek run --all-filesclean.