Skip to content

[incubator-kie-benchmarks-297] Enable exec-model benchmark for KBaseC… - #298

Merged
tkobayas merged 1 commit into
apache:mainfrom
tkobayas:enable-exec-model
May 25, 2026
Merged

[incubator-kie-benchmarks-297] Enable exec-model benchmark for KBaseC…#298
tkobayas merged 1 commit into
apache:mainfrom
tkobayas:enable-exec-model

Conversation

@tkobayas

Copy link
Copy Markdown
Contributor

…reationFromDrlBenchmark and BuildDRLWithoutKieBaseBenchmark

Closes #297

…reationFromDrlBenchmark and BuildDRLWithoutKieBaseBenchmark

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables running the build-time DRL benchmarks in both classic (DRL) and exec-model (canonical) modes, and updates the benchmark DRL resources to be compatible with exec-model compilation.

Changes:

  • Added a useCanonicalModel JMH parameter to KBaseCreationFromDrlBenchmark and BuildDRLWithoutKieBaseBenchmark.
  • Extended AbstractBuildtimeBenchmark to build either ExecutableModelProject (exec-model) or DrlProject (classic) based on the parameter.
  • Fixed DRL resources by adding the missing ArrayList import and using it for the global declaration.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
drools-benchmarks-parent/drools-benchmarks/src/main/resources/kbase-creation/drl-template.drl Adds ArrayList import and simplifies global type to support exec-model parsing.
drools-benchmarks-parent/drools-benchmarks/src/main/resources/kbase-creation/drl-kbase-creation-1k.drl Adds ArrayList import and updates global to unqualified ArrayList.
drools-benchmarks-parent/drools-benchmarks/src/main/resources/kbase-creation/drl-kbase-creation-5k.drl Adds ArrayList import and updates global to unqualified ArrayList.
drools-benchmarks-parent/drools-benchmarks/src/main/resources/kbase-creation/drl-kbase-creation-10k.drl Adds ArrayList import and updates global to unqualified ArrayList.
drools-benchmarks-parent/drools-benchmarks/src/main/java/org/drools/benchmarks/turtle/buildtime/KBaseCreationFromDrlBenchmark.java Adds useCanonicalModel param and passes it to KBase creation.
drools-benchmarks-parent/drools-benchmarks/src/main/java/org/drools/benchmarks/turtle/buildtime/BuildDRLWithoutKieBaseBenchmark.java Adds useCanonicalModel param and passes it to DRL build step.
drools-benchmarks-parent/drools-benchmarks/src/main/java/org/drools/benchmarks/turtle/buildtime/AbstractBuildtimeBenchmark.java Adds canonical-vs-classic build paths for both KieBase creation and KieBuilder buildAll.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tkobayas
tkobayas requested review from Rikkola, baldimir and yesamer May 22, 2026 02:36
@tkobayas
tkobayas merged commit 207ee80 into apache:main May 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable exec-model benchmark for KBaseCreationFromDrlBenchmark and BuildDRLWithoutKieBaseBenchmark

4 participants