[incubator-kie-benchmarks-297] Enable exec-model benchmark for KBaseC… - #298
Merged
Conversation
…reationFromDrlBenchmark and BuildDRLWithoutKieBaseBenchmark
There was a problem hiding this comment.
Pull request overview
Enables running the build-time DRL benchmarks in both classic (DRL) and exec-model (canonical) modes, and updates the benchmark DRL resources to be compatible with exec-model compilation.
Changes:
- Added a
useCanonicalModelJMH parameter toKBaseCreationFromDrlBenchmarkandBuildDRLWithoutKieBaseBenchmark. - Extended
AbstractBuildtimeBenchmarkto build eitherExecutableModelProject(exec-model) orDrlProject(classic) based on the parameter. - Fixed DRL resources by adding the missing
ArrayListimport and using it for theglobaldeclaration.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| drools-benchmarks-parent/drools-benchmarks/src/main/resources/kbase-creation/drl-template.drl | Adds ArrayList import and simplifies global type to support exec-model parsing. |
| drools-benchmarks-parent/drools-benchmarks/src/main/resources/kbase-creation/drl-kbase-creation-1k.drl | Adds ArrayList import and updates global to unqualified ArrayList. |
| drools-benchmarks-parent/drools-benchmarks/src/main/resources/kbase-creation/drl-kbase-creation-5k.drl | Adds ArrayList import and updates global to unqualified ArrayList. |
| drools-benchmarks-parent/drools-benchmarks/src/main/resources/kbase-creation/drl-kbase-creation-10k.drl | Adds ArrayList import and updates global to unqualified ArrayList. |
| drools-benchmarks-parent/drools-benchmarks/src/main/java/org/drools/benchmarks/turtle/buildtime/KBaseCreationFromDrlBenchmark.java | Adds useCanonicalModel param and passes it to KBase creation. |
| drools-benchmarks-parent/drools-benchmarks/src/main/java/org/drools/benchmarks/turtle/buildtime/BuildDRLWithoutKieBaseBenchmark.java | Adds useCanonicalModel param and passes it to DRL build step. |
| drools-benchmarks-parent/drools-benchmarks/src/main/java/org/drools/benchmarks/turtle/buildtime/AbstractBuildtimeBenchmark.java | Adds canonical-vs-classic build paths for both KieBase creation and KieBuilder buildAll. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yesamer
approved these changes
May 22, 2026
Rikkola
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…reationFromDrlBenchmark and BuildDRLWithoutKieBaseBenchmark
Closes #297