Core: Expose helper methods of partition statistics#16560
Conversation
6cfed35 to
f967c49
Compare
f967c49 to
02fbc95
Compare
|
@pvary @gaborkaszab Could you review this PR when you have time? |
|
Thanks for pinging me on this, @ebyhr ! I wasn't aware of such a limitation from the Trino side. I checked the functions that you changed to public and IMO they are very low level functions meant for internal usage. I'm just throwing out ideas here, but would it make sense to split the current
|
|
@gaborkaszab I had previously submitted such a PR (#14290), but unfortunately, it wasn't reviewed. I'll restore the PR once we've agreed on the approach. |
|
Thanks for the link, @ebyhr ! After a Quick Look it seems slightly different approach than what I suggested here: It makes the partition stats readers and writers injectable into the |
#14998 causes build failures in Trino / Starburst.
As I reported #14284, Trino doesn't allow the Hadoop-based Parquet library.
Therefore, the project uses some helper methods instead of relying solely on the reader and writer classes in the Iceberg library.
This PR makes some methods public to resolve the build failure.