Core: Fix flaky test by ensuring generateContentLength returns positive value#16539
Open
lilei1128 wants to merge 1 commit into
Open
Core: Fix flaky test by ensuring generateContentLength returns positive value#16539lilei1128 wants to merge 1 commit into
lilei1128 wants to merge 1 commit into
Conversation
Contributor
Author
|
Contributor
Author
|
close #16542 |
anoopj
approved these changes
May 26, 2026
Contributor
anoopj
left a comment
anoopj
left a comment
There was a problem hiding this comment.
The fix looks correct to me. Thank you for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generateContentLength() used random().nextInt(10_000) which could return 0.
When a DV's contentSizeInBytes is 0, SnapshotSummary skips writing the
"added-files-size" field due to the setIf(addedSize > 0, ...) guard,
causing testFileSizeSummaryWithDVs to fail with hasSize(19) vs actual 18.
Fix by returning 1 + random().nextInt(10_000) to guarantee a positive value.