All: Remove deprecated methods for 1.12.0#16449
Open
dramaticlly wants to merge 5 commits into
Open
Conversation
nastra
reviewed
May 22, 2026
| // TODO change to required in 1.12.0 | ||
| if (!properties().containsKey(S3_SIGNER_ENDPOINT) | ||
| && !properties().containsKey(RESTCatalogProperties.SIGNER_ENDPOINT)) { | ||
| LOG.warn( |
Contributor
There was a problem hiding this comment.
this shouldn't be removed. Instead, this should go through a Preconditions.checkArgument check
Contributor
Author
There was a problem hiding this comment.
yeah I think RESTCatalogProperties.SIGNER_ENDPOINT is replaced with RESTCatalogProperties.SIGNER_URI and we can rely on LINE 206 to ensure its existence. Sorry it's a bit messy right now
dramaticlly
force-pushed
the
1.12deprecation
branch
from
cadfa6b to
d62346b
Compare
dramaticlly
force-pushed
the
1.12deprecation
branch
2 times, most recently
from
ab4da8d to
aa6430d
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dramaticlly
force-pushed
the
1.12deprecation
branch
from
aa6430d to
0436357
Compare
…DeleteRowSchema - TestS3FileIOProperties: Add required signer.endpoint property since the deprecated default was removed - TestSparkWriterMetrics: Override checkRowStatistics and checkNotExistingRowStatistics to match behavior without positionDeleteRowSchema (consistent with Flink tests) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
BaseScan.io() and PositionDelete.set(path, pos, row)/row() still have callers and cannot be removed yet. Restore their deprecation annotations to preserve the original removal intent. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…io() The method had only 4 internal callers (DataScan, BaseDistributedDataScan) which are trivially replaced with table().io(). Also moves revapi entries to the 1.12.0 section with unified justification. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
@nastra do you want to take another look as now CI is green. I leave the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all methods, classes, and fields marked with "@deprecated will be removed in 1.12.0" across all modules, since 1.11.0 has been released.
Deleted Classes
SystemProperties→ useSystemConfigsPartitionStats→ usePartitionStatisticsinterface /BasePartitionStatisticsDataReader→ usePlannedDataReaderGenericAppenderFactory→ useGenericFileWriterFactoryBaseFileWriterFactory→ useRegistryBasedFileWriterFactoryS3SignRequest,S3SignResponse,S3SignRequestParser,S3SignResponseParser,S3ObjectMapper→ useRemoteSign*equivalentsNotable Non-Mechanical Changes
Beyond deleting deprecated code, the following adjustments were needed:
PositionDelete.set(path, pos, row)androw()— Kept without@Deprecated. Although the public deprecation notice said position deletes with row data are no longersupported, internal code (
BaseTaskWriter,BasePositionDeltaWriter,RewriteTablePathUtil,Avro) still relies on these methods.BaseScan.io()— Kept as a non-deprecatedprotectedmethod. Internal subclasses (DataScan,BaseDistributedDataScan) use it; the deprecation was for externalcallers.
HadoopFileIO.serializeConfWith()— Kept without@Deprecatedbecause it implements theHadoopConfigurableinterface contract. Also inlined constructor logic sincethe removed constructor was the delegation target.
BaseParquetReaders.createStructReader(List, StructType, Integer)— Changed from a concrete method (that delegated to the removed 2-param version) toabstract. Bothexisting subclasses (
InternalReader,GenericParquetReaders) already override it.RewriteTablePathUtil.PositionDeleteReaderWriter.writer()— The 4-arg method was adefaultdelegating to the removed 5-arg version. Made itabstract; updated allimplementors (
RewriteTablePathSparkActionin v3.5/v4.0/v4.1) to implement the 4-arg signature directly.S3V4RestSignerClient— Removed deprecated property fallback logic frombaseSignerUri(),endpoint(), andcheck(). The legacy properties (s3.signer.uri,s3.signer.endpoint) are no longer supported.Parquet.java— Removed theNETFLIX_UNSAFE_PARQUET_ID_FALLBACK_ENABLEDbranch; without the config, always useNameMapping.empty()(the safe default).MetricsConfig.forPositionDelete(Table)— All callers (FlinkAppenderFactory,RegistryBasedFileWriterFactory) updated to use the no-argforPositionDelete()sincerow-level position delete metrics are no longer supported.
GenericFileWriterFactory— Re-addedwriterPropertiesto the constructor and Builder since it was a public non-deprecated setter used byGenericAppenderHelperandkafka-connect
RecordUtils.