Flink: Throw UnsupportedOperationException for materialized tables#16079
Open
rmoff wants to merge 2 commits into
Open
Flink: Throw UnsupportedOperationException for materialized tables#16079rmoff wants to merge 2 commits into
rmoff wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
Contributor
Author
|
This is not stale, just needs a review :) |
pvary
reviewed
May 26, 2026
| throw new UnsupportedOperationException( | ||
| "Materialized tables are not supported by Iceberg's Flink catalog."); | ||
| } | ||
|
|
||
| Preconditions.checkArgument(table instanceof ResolvedCatalogTable, "table should be resolved"); |
Contributor
There was a problem hiding this comment.
I think this is the issue with the error message here. Could we be more explicit which could help the users?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creating a materialized table in Flink using an Iceberg catalog currently fails with a
cryptic
IllegalArgumentException: table should be resolvedfrom aPreconditions.checkArgumentdeep in
FlinkCatalog.createTable(). See #15318 for occurrence raised by a user.This PR adds an explicit
instanceof CatalogMaterializedTablecheck before that precondition,throwing a clear
UnsupportedOperationExceptionwith the message:"Materialized tables are not supported by Iceberg's Flink catalog."
Before
After
Test plan
testCreateMaterializedTableIsUnsupportedinTestFlinkCatalogTable(runs across all 3 catalog parametrizations)spotlessCheckpassesTestFlinkCatalogTabletests unaffected