Skip to content

feat: support geometry and geography types #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wirybeaver wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: support geometry and geography types #2933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
719e4fa
feat: support geometry and geography types
wirybeaver Jun 16, 2026
2b60f92
fix: decouple geography edge algorithm API
wirybeaver Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ once_cell = "1.20"
opendal = "0.57"
ordered-float = "4"
parquet = "58.4"
parquet-geospatial = "58.4"
pilota = "0.11.10"
pretty_assertions = "1.4"
pyo3 = "0.28"
Expand Down
5 changes: 4 additions & 1 deletion crates/catalog/glue/src/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,10 @@ impl SchemaVisitor for GlueSchemaBuilder {
PrimitiveType::Time | PrimitiveType::String | PrimitiveType::Uuid => {
"string".to_string()
}
PrimitiveType::Binary | PrimitiveType::Fixed(_) => "binary".to_string(),
PrimitiveType::Binary
| PrimitiveType::Fixed(_)
| PrimitiveType::Geometry(_)
| PrimitiveType::Geography(_) => "binary".to_string(),
PrimitiveType::Decimal { precision, scale } => {
format!("decimal({precision},{scale})")
}
Expand Down
5 changes: 4 additions & 1 deletion crates/catalog/hms/src/schema.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,10 @@ impl SchemaVisitor for HiveSchemaBuilder {
PrimitiveType::Time | PrimitiveType::String | PrimitiveType::Uuid => {
"string".to_string()
}
PrimitiveType::Binary | PrimitiveType::Fixed(_) => "binary".to_string(),
PrimitiveType::Binary
| PrimitiveType::Fixed(_)
| PrimitiveType::Geometry(_)
| PrimitiveType::Geography(_) => "binary".to_string(),
PrimitiveType::Decimal { precision, scale } => {
format!("decimal({precision},{scale})")
}
Expand Down
3 changes: 2 additions & 1 deletion crates/iceberg/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ moka = { version = "0.12.10", features = ["future"] }
murmur3 = { workspace = true }
once_cell = { workspace = true }
ordered-float = { workspace = true }
parquet = { workspace = true, features = ["async", "encryption"] }
parquet = { workspace = true, features = ["async", "encryption", "geospatial"] }
parquet-geospatial = { workspace = true }
rand = { workspace = true }
reqwest = { workspace = true }
roaring = { workspace = true }
Expand Down
66 changes: 66 additions & 0 deletions crates/iceberg/public-api.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1408,6 +1408,29 @@ impl serde_core::ser::Serialize for iceberg::spec::DataFileFormat where Self: co
pub fn iceberg::spec::DataFileFormat::serialize<__S>(&self, serializer: __S) -> core::result::Result<<__S as serde_core::ser::Serializer>::Ok, <__S as serde_core::ser::Serializer>::Error> where __S: serde_core::ser::Serializer
impl<'de> serde_core::de::Deserialize<'de> for iceberg::spec::DataFileFormat where Self: core::str::traits::FromStr, <Self as core::str::traits::FromStr>::Err: core::fmt::Display
pub fn iceberg::spec::DataFileFormat::deserialize<__D>(deserializer: __D) -> core::result::Result<Self, <__D as serde_core::de::Deserializer>::Error> where __D: serde_core::de::Deserializer<'de>
pub enum iceberg::spec::EdgeInterpolationAlgorithm
pub iceberg::spec::EdgeInterpolationAlgorithm::Andoyer
pub iceberg::spec::EdgeInterpolationAlgorithm::Karney
pub iceberg::spec::EdgeInterpolationAlgorithm::Spherical
pub iceberg::spec::EdgeInterpolationAlgorithm::Thomas
pub iceberg::spec::EdgeInterpolationAlgorithm::Vincenty
impl core::clone::Clone for iceberg::spec::EdgeInterpolationAlgorithm
pub fn iceberg::spec::EdgeInterpolationAlgorithm::clone(&self) -> iceberg::spec::EdgeInterpolationAlgorithm
impl core::cmp::Eq for iceberg::spec::EdgeInterpolationAlgorithm
impl core::cmp::PartialEq for iceberg::spec::EdgeInterpolationAlgorithm
pub fn iceberg::spec::EdgeInterpolationAlgorithm::eq(&self, other: &iceberg::spec::EdgeInterpolationAlgorithm) -> bool
impl core::default::Default for iceberg::spec::EdgeInterpolationAlgorithm
pub fn iceberg::spec::EdgeInterpolationAlgorithm::default() -> iceberg::spec::EdgeInterpolationAlgorithm
impl core::fmt::Debug for iceberg::spec::EdgeInterpolationAlgorithm
pub fn iceberg::spec::EdgeInterpolationAlgorithm::fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result
impl core::hash::Hash for iceberg::spec::EdgeInterpolationAlgorithm
pub fn iceberg::spec::EdgeInterpolationAlgorithm::hash<__H: core::hash::Hasher>(&self, state: &mut __H)
impl core::marker::Copy for iceberg::spec::EdgeInterpolationAlgorithm
impl core::marker::StructuralPartialEq for iceberg::spec::EdgeInterpolationAlgorithm
impl serde_core::ser::Serialize for iceberg::spec::EdgeInterpolationAlgorithm
pub fn iceberg::spec::EdgeInterpolationAlgorithm::serialize<__S>(&self, __serializer: __S) -> core::result::Result<<__S as serde_core::ser::Serializer>::Ok, <__S as serde_core::ser::Serializer>::Error> where __S: serde_core::ser::Serializer
impl<'de> serde_core::de::Deserialize<'de> for iceberg::spec::EdgeInterpolationAlgorithm
pub fn iceberg::spec::EdgeInterpolationAlgorithm::deserialize<__D>(__deserializer: __D) -> core::result::Result<Self, <__D as serde_core::de::Deserializer>::Error> where __D: serde_core::de::Deserializer<'de>
#[repr(u8)] pub enum iceberg::spec::FormatVersion
pub iceberg::spec::FormatVersion::V1 = 1
pub iceberg::spec::FormatVersion::V2 = 2
Expand Down Expand Up @@ -1597,6 +1620,8 @@ pub iceberg::spec::PrimitiveType::Decimal::scale: u32
pub iceberg::spec::PrimitiveType::Double
pub iceberg::spec::PrimitiveType::Fixed(u64)
pub iceberg::spec::PrimitiveType::Float
pub iceberg::spec::PrimitiveType::Geography(iceberg::spec::GeographyType)
pub iceberg::spec::PrimitiveType::Geometry(iceberg::spec::GeometryType)
pub iceberg::spec::PrimitiveType::Int
pub iceberg::spec::PrimitiveType::Long
pub iceberg::spec::PrimitiveType::String
Expand Down Expand Up @@ -1973,6 +1998,47 @@ impl serde_core::ser::Serialize for iceberg::spec::FieldSummary
pub fn iceberg::spec::FieldSummary::serialize<__S>(&self, __serializer: __S) -> core::result::Result<<__S as serde_core::ser::Serializer>::Ok, <__S as serde_core::ser::Serializer>::Error> where __S: serde_core::ser::Serializer
impl<'de> serde_core::de::Deserialize<'de> for iceberg::spec::FieldSummary
pub fn iceberg::spec::FieldSummary::deserialize<__D>(__deserializer: __D) -> core::result::Result<Self, <__D as serde_core::de::Deserializer>::Error> where __D: serde_core::de::Deserializer<'de>
pub struct iceberg::spec::GeographyType
impl iceberg::spec::GeographyType
pub fn iceberg::spec::GeographyType::algorithm(&self) -> iceberg::spec::EdgeInterpolationAlgorithm
pub fn iceberg::spec::GeographyType::crs(&self) -> core::option::Option<&str>
pub fn iceberg::spec::GeographyType::new(crs: core::option::Option<alloc::string::String>, algorithm: iceberg::spec::EdgeInterpolationAlgorithm) -> iceberg::Result<Self>
impl core::clone::Clone for iceberg::spec::GeographyType
pub fn iceberg::spec::GeographyType::clone(&self) -> iceberg::spec::GeographyType
impl core::cmp::Eq for iceberg::spec::GeographyType
impl core::cmp::PartialEq for iceberg::spec::GeographyType
pub fn iceberg::spec::GeographyType::eq(&self, other: &iceberg::spec::GeographyType) -> bool
impl core::default::Default for iceberg::spec::GeographyType
pub fn iceberg::spec::GeographyType::default() -> Self
impl core::fmt::Debug for iceberg::spec::GeographyType
pub fn iceberg::spec::GeographyType::fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result
impl core::hash::Hash for iceberg::spec::GeographyType
pub fn iceberg::spec::GeographyType::hash<__H: core::hash::Hasher>(&self, state: &mut __H)
impl core::marker::StructuralPartialEq for iceberg::spec::GeographyType
impl serde_core::ser::Serialize for iceberg::spec::GeographyType
pub fn iceberg::spec::GeographyType::serialize<__S>(&self, __serializer: __S) -> core::result::Result<<__S as serde_core::ser::Serializer>::Ok, <__S as serde_core::ser::Serializer>::Error> where __S: serde_core::ser::Serializer
impl<'de> serde_core::de::Deserialize<'de> for iceberg::spec::GeographyType
pub fn iceberg::spec::GeographyType::deserialize<__D>(__deserializer: __D) -> core::result::Result<Self, <__D as serde_core::de::Deserializer>::Error> where __D: serde_core::de::Deserializer<'de>
pub struct iceberg::spec::GeometryType
impl iceberg::spec::GeometryType
pub fn iceberg::spec::GeometryType::crs(&self) -> core::option::Option<&str>
pub fn iceberg::spec::GeometryType::new(crs: core::option::Option<alloc::string::String>) -> iceberg::Result<Self>
impl core::clone::Clone for iceberg::spec::GeometryType
pub fn iceberg::spec::GeometryType::clone(&self) -> iceberg::spec::GeometryType
impl core::cmp::Eq for iceberg::spec::GeometryType
impl core::cmp::PartialEq for iceberg::spec::GeometryType
pub fn iceberg::spec::GeometryType::eq(&self, other: &iceberg::spec::GeometryType) -> bool
impl core::default::Default for iceberg::spec::GeometryType
pub fn iceberg::spec::GeometryType::default() -> iceberg::spec::GeometryType
impl core::fmt::Debug for iceberg::spec::GeometryType
pub fn iceberg::spec::GeometryType::fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result
impl core::hash::Hash for iceberg::spec::GeometryType
pub fn iceberg::spec::GeometryType::hash<__H: core::hash::Hasher>(&self, state: &mut __H)
impl core::marker::StructuralPartialEq for iceberg::spec::GeometryType
impl serde_core::ser::Serialize for iceberg::spec::GeometryType
pub fn iceberg::spec::GeometryType::serialize<__S>(&self, __serializer: __S) -> core::result::Result<<__S as serde_core::ser::Serializer>::Ok, <__S as serde_core::ser::Serializer>::Error> where __S: serde_core::ser::Serializer
impl<'de> serde_core::de::Deserialize<'de> for iceberg::spec::GeometryType
pub fn iceberg::spec::GeometryType::deserialize<__D>(__deserializer: __D) -> core::result::Result<Self, <__D as serde_core::de::Deserializer>::Error> where __D: serde_core::de::Deserializer<'de>
pub struct iceberg::spec::ListType
pub iceberg::spec::ListType::element_field: iceberg::spec::NestedFieldRef
impl iceberg::spec::ListType
Expand Down
Loading
Loading