feat(table): allow explicit runtime for static tables#2501
Open
officialasishkumar wants to merge 1 commit into
Open
feat(table): allow explicit runtime for static tables#2501officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
Add StaticTable constructors that accept an iceberg Runtime directly while preserving the existing current-runtime based constructors. Cover both metadata-file construction and construction from in-memory metadata outside a Tokio context.
CTTY
reviewed
May 26, 2026
Collaborator
CTTY
left a comment
CTTY
left a comment
There was a problem hiding this comment.
Hi @officialasishkumar , thanks for picking this up!
I think we should change the API and ask for an explicit runtime because runtime is always mandatory, not adding a new API. If users want to use the current runtime, they can call Runtime::try_current()
| @@ -302,12 +302,23 @@ impl StaticTable { | |||
| metadata: TableMetadata, | |||
| table_ident: TableIdent, | |||
| file_io: FileIO, | |||
Collaborator
There was a problem hiding this comment.
We should ask for an explicit runtime here rather than falling back to the current runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
StaticTable::from_metadata_with_runtimefor constructing static tables with an explicit Iceberg runtime.StaticTable::from_metadata_file_with_runtimefor metadata-file construction with an explicit runtime.Are these changes tested?
CARGO_TARGET_DIR=/tmp/iceberg-rust-target cargo test --locked -p iceberg with_runtime -- --nocapturecargo fmt --all -- --checkgit diff --check