fix(table): validate snapshot timestamp drift#3443
Open
GayathriSrividya wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Align snapshot timestamp validation with the Java and Rust implementations by rejecting timestamps that drift backwards by more than one minute. Small clock skew remains allowed.
This also validates parsed table metadata:
snapshot-logentries remain sorted within the one-minute tolerancelast-updated-msis not more than one minute behind the latest snapshot-log entryAttribution
This revives the implementation from #3062 by @mrutunjay-kinagi. I cherry-picked the original authored commits onto the latest
main, preserving authorship, and am reopening it because the earlier PR was closed automatically after inactivity. It includes the metadata-level validation added in response to @Fokko's review.Verification
make lintmake test(3713 passed, 1534 deselected)