fix(manifest): reject row ID allocation overflow - #1627
Open
fallintoplace wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Validate every row-ID range assigned by the v3 manifest writers before advancing the cursor:
int64overflow while allocating a manifest rangeNextRowIDonly after manifest validation and encoding succeedThe same checked arithmetic is used by
WriteManifestV3when it returns the next available row ID.Why
V3 row lineage requires non-negative row IDs. The manifest-list writer previously added
existing_rows_countandadded_rows_countdirectly to its cursor. Nearmath.MaxInt64, that addition could wrap and assign a negativefirst_row_idto the next manifest. Invalid counts or a later validation failure could also move the in-memory cursor even though the manifest was rejected.This could produce overlapping or invalid row-ID ranges in metadata written near the boundary.
Testing
WriteManifestV3range overflowgo test .go vet .