fix(dv): reject trailing bitmap data - #1625
Open
fallintoplace wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject trailing bytes after a portable roaring position bitmap.
Problem
The portable format starts with the number of keyed bitmaps, so that count frames the complete payload. The decoder reads exactly that many entries but does not verify that the input is exhausted afterward. As a result, an otherwise valid bitmap with arbitrary trailing bytes is accepted and the extra data is silently ignored.
For deletion vectors this weakens corruption detection because malformed inner bitmap data can pass decoding even when the outer DV length and CRC are valid.
Fix
After decoding the declared bitmap entries, require the input reader to have no bytes remaining.
Tests
Added framing coverage for empty and multi-key non-empty bitmaps. An end-to-end DV envelope test also appends bytes to a valid bitmap, rebuilds the matching length and CRC, and verifies the contextual decode error.