fix(table): keep generated snapshot IDs non-negative - #1619
Open
fallintoplace wants to merge 2 commits into
Open
fix(table): keep generated snapshot IDs non-negative#1619fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Clear the sign bit before converting the UUID-derived snapshot ID to
int64. The UUID folding logic is extracted into a small deterministic helper for regression coverage.Why
Negating a negative value does not make
math.MinInt64positive because signed negation overflows back to the same value. Clearing the sign bit guarantees that generated snapshot IDs are nonnegative for every input.Testing
go test ./table