fix(table): reject ambiguous row-id columns in position deltas - #1616
Open
fallintoplace wants to merge 2 commits into
Open
fix(table): reject ambiguous row-id columns in position deltas#1616fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Require position-delta batches to contain at most one
_row_idcolumn. The shared lookup is used byReinsert,Insert, and the null-column append path.Why
Arrow schemas can contain duplicate field names. Selecting the first
_row_idsilently made reserved row-lineage metadata ambiguous and could ignore a conflicting or malformed second column.Testing
_row_idcoverage for bothReinsertandInsertgo test ./table