fix(rest): validate namespace identifier components - #1614
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add shared namespace identifier validation in the catalog package and use it at REST namespace boundaries. Namespace components now follow the same rules as table, view, and function identifier components.
Why
REST namespace operations previously checked only that an identifier had at least one component. Empty components, path separators, dot components, and control characters were accepted even though object identifiers inside those namespaces reject them.
Testing
go test ./catalog ./catalog/rest