fix(manifest): reject unsupported format versions - #1612
Open
fallintoplace wants to merge 2 commits into
Open
Conversation
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
fallintoplace
force-pushed
the
fix/manifest-reject-unsupported-versions
branch
from
August 1, 2026 16:09
20e28f2 to
199ba1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Validate manifest and manifest-list format versions before selecting a reader schema. Versions 1, 2, and 3 remain supported, and a missing version still defaults to version 1.
Why
Manifest lists previously routed every version other than 1 through the v2/v3 reader. Manifest files also accepted arbitrary integers. Unknown versions could therefore be interpreted with a schema whose semantics may not match the file.
Testing
go test ./...