fix(expr): reject trailing data after boolean expressions - #1609
Open
fallintoplace wants to merge 2 commits into
Open
fix(expr): reject trailing data after boolean expressions#1609fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Fully decode top-level boolean expressions before returning
AlwaysTrueorAlwaysFalse. This rejects malformed input containing a valid boolean followed by additional JSON or other trailing data.Why
The expression decoder previously inspected only the first token for booleans. Inputs such as
true falsewere therefore accepted even though they are not valid JSON values. Object expressions already reject trailing data throughjson.Unmarshal.Testing
go test ./...