fix(puffin): reject trailing data in footer payloads - #1580
Open
fallintoplace wants to merge 2 commits into
Open
fix(puffin): reject trailing data in footer payloads#1580fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
fallintoplace
force-pushed
the
fix/puffin-footer-trailing-data
branch
from
August 1, 2026 16:14
099c19a to
02e5987
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
After decoding the Puffin footer object, require the bounded footer payload reader to contain only JSON whitespace before EOF.
Why
A single
json.Decoder.Decodecall accepted the first JSON value and silently ignored a second value or non-whitespace garbage, even though the trailer declared those bytes as part of the footer payload.Unknown fields within the footer object remain allowed for forward compatibility.
Testing
go test ./puffingo vet ./puffin