WebDAV VFS and metadata type #7123#7124
Open
bamaer wants to merge 8 commits into
Open
Conversation
HopWebDavConnectionFileName wraps Webdav4FileName so getURI/getRootURI/ getFriendlyURI use the connection metadata name (e.g. nextcloud:///path) while wire host/path stay on webdav4 for HTTP. Undo: git revert this commit (files: HopWebDavLogicalUris.java, HopWebDavConnectionFileName.java, parser + tests). Co-authored-by: Cursor <cursoragent@cursor.com>
Webdav4FileSystem.createFile was still attaching plain Webdav4FileName from PROPFIND/listing. Use HopWebDavConnectionFileSystem to wrap every Webdav4FileName so HopVfsFileDialog and getURI() show the metadata scheme. Undo: git revert this commit. Co-authored-by: Cursor <cursoragent@cursor.com>
doListChildrenResolved returns FileObjects that bypass createFile; subclass Webdav4FileObject to re-resolve children with HopWebDavConnectionFileName. Undo: git revert this commit. Co-authored-by: Cursor <cursoragent@cursor.com>
DefaultFileSystemManager.resolveName picks the provider from parent.getScheme(); HopWebDavConnectionFileName still reported webdav4 so PROPFIND child resolution used the global Webdav4FileProvider. Return the connection name from getScheme, keep wireScheme for Webdav4FileName children, and parse resolveName-style URIs (rootURI + full wire path) into the correct synthetic webdav4 URL. Undo: git revert this commit. Co-authored-by: Cursor <cursoragent@cursor.com>
bamaer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean install apache-rat:checkto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.git rebase -i.addresses #123), if applicable.To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.