Skip to content

HBASE-30155 MobFileCleanerChore does not shut down its internal execu…#8254

Merged
liuxiaocs7 merged 1 commit into
apache:branch-2from
liuxiaocs7:HBASE-30155-branch-2
May 19, 2026
Merged

HBASE-30155 MobFileCleanerChore does not shut down its internal execu…#8254
liuxiaocs7 merged 1 commit into
apache:branch-2from
liuxiaocs7:HBASE-30155-branch-2

Conversation

@liuxiaocs7
Copy link
Copy Markdown
Member

…… (#8222)

@liuxiaocs7 liuxiaocs7 requested a review from Copilot May 19, 2026 04:27
@liuxiaocs7 liuxiaocs7 added the backport This PR is a back port of some issue or issues already committed to master label May 19, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses HBASE-30155 by ensuring MobFileCleanerChore properly tears down its internally managed ThreadPoolExecutor when the chore is shut down, preventing lingering executor threads after cleanup.

Changes:

  • Override ScheduledChore.cleanup() in MobFileCleanerChore to shut down the internal executor.
  • Add a focused unit test validating that shutdown() results in the executor being shut down.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java Adds cleanup() override to shut down the internal ThreadPoolExecutor on chore shutdown.
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobFileCleanerChore.java Adds a unit test asserting MobFileCleanerChore.shutdown() shuts down the internal executor.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@liuxiaocs7 liuxiaocs7 merged commit 4294ef6 into apache:branch-2 May 19, 2026
47 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a back port of some issue or issues already committed to master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants