Skip to content

HBASE-30166: Attempt to fix flakeyness in TestPrefetchPersistence #8252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wchevreuil wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −3
Open

HBASE-30166: Attempt to fix flakeyness in TestPrefetchPersistence #8252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6c501b
HBASE-30166: Attempt to fix flakeyness in TestPrefetchPersistence
wchevreuil May 18, 2026
1c9efde
spotless
wchevreuil May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions ...server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestPrefetchPersistence.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import org.apache.hadoop.hbase.regionserver.StoreFileWriter;
import org.apache.hadoop.hbase.testclassification.IOTests;
import org.apache.hadoop.hbase.testclassification.LargeTests;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.TestTemplate;
Expand Down Expand Up @@ -127,15 +128,23 @@ public void testPrefetchPersistence() throws Exception {
assertTrue(usedSize != 0);
assertTrue(bucketCache.fullyCachedFiles.containsKey(storeFile.getName()));
assertTrue(bucketCache.fullyCachedFiles.containsKey(storeFile2.getName()));
}

@AfterEach
public void cleanup() {
TEST_UTIL.cleanupTestDir();
}

public void readStoreFile(Path storeFilePath) throws Exception {
// Open the file
HFile.Reader reader = HFile.createReader(fs, storeFilePath, cacheConf, true, conf);
while (!reader.prefetchComplete()) {
// Sleep for a bit
Thread.sleep(1000);
int retries = 0;
while (
!reader.prefetchComplete()
&& !bucketCache.fullyCachedFiles.containsKey(storeFilePath.getName()) && retries < 5
) {
Thread.sleep(500);
retries++;
}
}

Expand Down
Loading