HDFS-17924. Improve NameNode edit log rolling controls by kokonguyen191 · Pull Request #8509 · apache/hadoop

kokonguyen191 · 2026-05-22T08:23:24Z

Description of PR

Currently, all 3 kinds of NNs trigger rollEditLog at some time interval and based on the number of edits using a threshold check.

If a subcluster has a lot of observers, active can roll very frequently, up to dozens of times per hour. This ticket aims improve that via 2 configurable features:

Only active should perform rollEditLog periodically, and it should guarantee a roll as long as there's something to roll, at a reasonable interval.
Standby and observer NNs can opt out of sending rollEditLog.

How was this patch tested?

UT, and a small test cluster of a few nodes.

hadoop-yetus · 2026-05-23T20:55:47Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	43m 25s		trunk passed
+1 💚	compile	1m 39s		trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚	compile	1m 43s		trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚	checkstyle	1m 44s		trunk passed
+1 💚	mvnsite	1m 53s		trunk passed
+1 💚	javadoc	1m 46s		trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚	javadoc	1m 32s		trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚	spotbugs	4m 14s		trunk passed
+1 💚	shadedclient	33m 4s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 19s		the patch passed
+1 💚	compile	1m 13s		the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚	javac	1m 13s		the patch passed
+1 💚	compile	1m 24s		the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚	javac	1m 24s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	1m 26s	/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 326 unchanged - 3 fixed = 327 total (was 329)
+1 💚	mvnsite	1m 32s		the patch passed
+1 💚	javadoc	1m 1s		the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚	javadoc	1m 4s		the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚	spotbugs	4m 10s		the patch passed
+1 💚	shadedclient	33m 21s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	220m 39s		hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 44s		The patch does not generate ASF License warnings.
		357m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8509/1/artifact/out/Dockerfile
GITHUB PR	#8509
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux 841c934b78fc 5.15.0-177-generic #187-Ubuntu SMP Sat Apr 11 22:54:33 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `b8160f9`
Default Java	Ubuntu-17.0.18+8-Ubuntu-124.04.1
Multi-JDK versions	/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.10+7-Ubuntu-124.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.18+8-Ubuntu-124.04.1
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8509/1/testReport/
Max. process+thread count	3573 (vs. ulimit of 10000)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8509/1/console
versions	git=2.43.0 maven=3.9.15 spotbugs=4.9.7
Powered by	Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

ZanderXu

Make sense.

Leave some minor comments.

ZanderXu · 2026-05-27T06:40:30Z

./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:4669: "Initializing log roller with parameters rollThreshold={}, maxRollIntervalMs={}, sleepIntervalMs={}",: Line is longer than 100 characters (found 111). [LineLength]

@kokonguyen191 please fix this check style issue.

ZanderXu

LGTM + 1

hadoop-yetus · 2026-05-27T13:19:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 37s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	45m 24s		trunk passed
+1 💚	compile	1m 51s		trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚	compile	1m 48s		trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚	checkstyle	1m 59s		trunk passed
+1 💚	mvnsite	2m 3s		trunk passed
+1 💚	javadoc	1m 29s		trunk passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚	javadoc	1m 33s		trunk passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚	spotbugs	4m 23s		trunk passed
+1 💚	shadedclient	33m 45s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 23s		the patch passed
+1 💚	compile	1m 16s		the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚	javac	1m 16s		the patch passed
+1 💚	compile	1m 17s		the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚	javac	1m 17s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 19s		hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 326 unchanged - 3 fixed = 326 total (was 329)
+1 💚	mvnsite	1m 25s		the patch passed
+1 💚	javadoc	0m 58s		the patch passed with JDK Ubuntu-21.0.10+7-Ubuntu-124.04
+1 💚	javadoc	1m 1s		the patch passed with JDK Ubuntu-17.0.18+8-Ubuntu-124.04.1
+1 💚	spotbugs	3m 48s		the patch passed
+1 💚	shadedclient	30m 46s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	218m 4s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 48s		The patch does not generate ASF License warnings.
		355m 4s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.datanode.fsdataset.impl.TestFsVolumeList

Subsystem	Report/Notes
Docker	ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8509/3/artifact/out/Dockerfile
GITHUB PR	#8509
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux e9cb0224f9bd 5.15.0-177-generic #187-Ubuntu SMP Sat Apr 11 22:54:33 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7981547`
Default Java	Ubuntu-17.0.18+8-Ubuntu-124.04.1
Multi-JDK versions	/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.10+7-Ubuntu-124.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.18+8-Ubuntu-124.04.1
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8509/3/testReport/
Max. process+thread count	3014 (vs. ulimit of 10000)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8509/3/console
versions	git=2.43.0 maven=3.9.15 spotbugs=4.9.7
Powered by	Apache Yetus 0.14.1 https://yetus.apache.org

This message was automatically generated.

kokonguyen191 · 2026-05-28T12:33:19Z

Seems to be flaky UT, failed test passes normally on my laptop

HDFS-17924. Improve NameNode edit log rolling controls

b8160f9

github-actions Bot added HDFS trunk labels May 22, 2026

ZanderXu reviewed May 26, 2026

View reviewed changes

Comment thread ...s-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java Outdated

HDFS-17924. Extract helper method

72c042f

ZanderXu approved these changes May 27, 2026

View reviewed changes

HDFS-17924. Reformat logging lines

7981547

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-17924. Improve NameNode edit log rolling controls#8509

HDFS-17924. Improve NameNode edit log rolling controls#8509
kokonguyen191 wants to merge 3 commits into
apache:trunkfrom
kokonguyen191:HDFS-17924

kokonguyen191 commented May 22, 2026

Uh oh!

hadoop-yetus commented May 23, 2026

Uh oh!

ZanderXu left a comment

Uh oh!

Uh oh!

ZanderXu commented May 27, 2026

Uh oh!

ZanderXu left a comment

Uh oh!

hadoop-yetus commented May 27, 2026

Uh oh!

kokonguyen191 commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kokonguyen191 commented May 22, 2026

Description of PR

How was this patch tested?

Uh oh!

hadoop-yetus commented May 23, 2026

Uh oh!

ZanderXu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ZanderXu commented May 27, 2026

Uh oh!

ZanderXu left a comment

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented May 27, 2026

Uh oh!

kokonguyen191 commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants