HDFS-17923. WebUI file explorer: Trash support, upload progress, rename, and UX improvements#8508
Open
magnuma3 wants to merge 1 commit into
Open
HDFS-17923. WebUI file explorer: Trash support, upload progress, rename, and UX improvements#8508magnuma3 wants to merge 1 commit into
magnuma3 wants to merge 1 commit into
Conversation
|
💔 -1 overall
This message was automatically generated. |
…me, and UX improvements
1cae069 to
85cbd78
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
HDFS-17923
The WebUI file explorer (/explorer.html) is the main entry point of HDFS for
many users in our environment. Most of them access HDFS through browser
behind Knox gateway, not by hdfs CLI. But current file explorer is missing
some basic features that users expect from a file manager today.
We have run patched version of file explorer on our internal 3.1.2 fork for
more than 2 year. It serves daily user traffic without big issue. We want to
contribute the general part to upstream as one patch.
Adds the following to
/explorer.html:GETHOMEDIRECTORY) instead of/.?p=<urlencoded-path>query.<homedir>/.Trash/Current/<path>usingop=RENAME&renameoptions=TO_TRASHinstead of
op=DELETE&recursive=true. Two guards reject moving a paththat is already inside Trash, or that contains Trash root. Destination
name collision is handled by
.1,.2suffix.op=RENAME.hdfs://<ns><path>to clipboard.Original UI
Enhanced UI
How was this patch tested?
manual smoke on a running NameNode
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?AI Tooling
If an AI tool was used:
where is the name of the AI tool used.
https://www.apache.org/legal/generative-tooling.html