[#11829] fix(doris): support replication allocation property#11877
Open
hutiefang76 wants to merge 1 commit into
Open
[#11829] fix(doris): support replication allocation property#11877hutiefang76 wants to merge 1 commit into
hutiefang76 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR lets the JDBC Doris catalog accept the Doris 2.1+
replication_allocationtable property.It also keeps the existing single-BE fallback behavior for old-style
replication_num, but skips that automaticreplication_num=1injection when the user has already providedreplication_allocation. Doris treats those two properties as mutually exclusive, so adding both can make table creation fail.Why
replication_allocationis valid Doris table syntax, but Gravitino did not register it in the Doris table property metadata. In single-backend environments, Gravitino could also addreplication_numautomatically, which conflicts with the user-supplied allocation policy.Tests
JAVA_HOME=$(/usr/libexec/java_home -v 17) ./gradlew :catalogs:catalog-jdbc-doris:test --tests org.apache.gravitino.catalog.doris.TestDorisCatalog --tests org.apache.gravitino.catalog.doris.operation.TestDorisTableOperationsSqlGeneration -PskipITs git diff --checkCloses #11829