[#10682] feat(iceberg-rest): Implement Iceberg REST remote-signing for S3#11854
Open
lasdf1234 wants to merge 1 commit into
Open
[#10682] feat(iceberg-rest): Implement Iceberg REST remote-signing for S3#11854lasdf1234 wants to merge 1 commit into
lasdf1234 wants to merge 1 commit into
Conversation
…ing for S3
Add POST .../tables/{table}/sign, remote-signing access delegation, and
client config injection so Spark/PyIceberg can use pre-signed S3 URLs instead
of vended cloud credentials.
Co-authored-by: Cursor <cursoragent@cursor.com>
Code Coverage Report
Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement Iceberg REST remote signing for the Gravitino Iceberg REST server:
POST .../namespaces/{namespace}/tables/{table}/signinIcebergTableOperations, acceptingRemoteSignRequestand returningRemoteSignResponsewithCache-Control: private.X-Iceberg-Access-Delegation: remote-signingviaIcebergAccessDelegationand propagate it throughIcebergRequestContextand the table/namespace dispatcher chain.s3.remote-signing-enabled=truesigner.endpoint=v1/{prefix}/namespaces/{namespace}/tables/{table}/signS3RemoteRequestSignerusing Gravitino credential providers (S3SecretKeyCredential,S3TokenCredential,AwsIrsaCredential), and validate sign URIs stay within table storage prefixes.Endpoint.V1_TABLE_REMOTE_SIGNin/v1/configendpoints.FederatedCatalogWrapper.Why are the changes needed?
Fix: #10682
The Iceberg REST server previously rejected
remote-signingand did not expose the/signendpoint. This is a gap against the Iceberg REST spec and blocks clients (for example Spark and PyIceberg) that prefer pre-signed S3 URLs over receiving cloud credentials directly.Does this PR introduce any user-facing change?
Yes.
X-Iceberg-Access-Delegation: remote-signingon create/load/register table.s3.remote-signing-enabledandsigner.endpointin the load/create/register response config.POST .../tables/{table}/signand advertises it in/v1/config.gravitino.iceberg-rest.data-access=remote-signingcan be advertised to REST clients via/v1/configdefaults.S3 is the only supported remote-sign provider in this PR.
How was this patch tested?
./gradlew :iceberg:iceberg-rest-server:test -PskipITs./gradlew :iceberg:iceberg-rest-server:test --tests org.apache.gravitino.iceberg.service.sign.* --tests org.apache.gravitino.iceberg.service.TestIcebergAccessDelegation --tests org.apache.gravitino.iceberg.service.rest.TestIcebergConfig.testConfigRemoteSignEndpoint -PskipITs