[lake] Fix DvTableReadableSnapshotRetriever scanning wrong snapshot#3396
Open
luoyuxia wants to merge 1 commit into
Open
[lake] Fix DvTableReadableSnapshotRetriever scanning wrong snapshot#3396luoyuxia wants to merge 1 commit into
luoyuxia wants to merge 1 commit into
Conversation
…ue to ineffective options getBucketsWithoutL0AndWithL0() passed SCAN_SNAPSHOT_ID and BATCH_SCAN_MODE via table options to store().newScan(), but these options are only consumed by table-level scans (DataTableBatchScan), not by store-level scans (AbstractFileStoreScan). This means the scan always hit the latest snapshot instead of the specified one. Fix by using the direct .withSnapshot(snapshot) API on FileStoreScan, consistent with getBucketsWithFlushedL0() in the same file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getBucketsWithoutL0AndWithL0()passedSCAN_SNAPSHOT_IDandBATCH_SCAN_MODEvia table options tostore().newScan(), but these options are only consumed by table-level scans (DataTableBatchScan), not by store-level scans (AbstractFileStoreScan). This means the scan always hit the latest snapshot instead of the specified one..withSnapshot(snapshot)API onFileStoreScan, consistent withgetBucketsWithFlushedL0()in the same file.CoreOptionsimport.Test Plan
DvTableReadableSnapshotRetrieverTest,FlinkUnionReadDvTableITCase)🤖 Generated with Claude Code