[elixir] feat: Extend Fluss.Config with scanner tuning options#574
Open
nicolazar wants to merge 2 commits into
Open
[elixir] feat: Extend Fluss.Config with scanner tuning options#574nicolazar wants to merge 2 commits into
nicolazar wants to merge 2 commits into
Conversation
This commit adds 8 more scanner-tuning fields to NifConfig, covering the remote log prefetch, download concurrency, max poll records and fetch size/time limits.
This commit adds 8 scanner-tuning fields to Fluss.Config with corresponding set_* setters: remote prefetch count, remote log read concurrency, file download thread count, max poll records and fetch size/time bounds.
Member
fresh-borzoni
left a comment
fresh-borzoni
left a comment
There was a problem hiding this comment.
@nicolazar Ty for the PR, LGTM overall, one comment
|
|
||
| @spec set_remote_file_download_thread_num(t(), non_neg_integer()) :: t() | ||
| def set_remote_file_download_thread_num(%__MODULE__{} = config, threads) | ||
| when is_integer(threads), |
Member
There was a problem hiding this comment.
nit: do you mind to tighten the guards to match type specs we use?
here and in other setters through config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #568, part of #463
Brief change log
This PR follows up on #566 to extend Fluss.Config - this time with 8 more scanner tuning options, such as remote log prefetch, download concurrency, max poll records, fetch size/time limits.
We follow the same approach as in the linked PR.
Tests
Additional tests cover the newly added options, one per field.