Skip to content

[FLINK-39753][state/rocksdb] Close ColumnFamilyOptions from getDescriptor() in Compactor #28251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidradl merged 1 commit into from
May 27, 2026
Merged

[FLINK-39753][state/rocksdb] Close ColumnFamilyOptions from getDescriptor() in Compactor #28251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/sstmerge/Compactor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
package org.apache.flink.state.rocksdb.sstmerge;

import org.rocksdb.ColumnFamilyHandle;
import org.rocksdb.ColumnFamilyOptions;
import org.rocksdb.CompactionJobInfo;
import org.rocksdb.CompactionOptions;
import org.rocksdb.RocksDB;
Expand Down Expand Up @@ -51,7 +52,13 @@ public Compactor(CompactionTarget target, long targetOutputFileSize) {
}

void compact(ColumnFamilyHandle cfName, int level, List<String> files) throws RocksDBException {
int outputLevel = Math.min(level + 1, cfName.getDescriptor().getOptions().numLevels() - 1);
// FLINK-39753: getDescriptor() allocates a new native ColumnFamilyOptions on every call.
// Closing it is required to release the native object and its reference to the shared
// block cache; leaking it keeps the LRUCache alive and grows native memory until OOM.
final int outputLevel;
try (ColumnFamilyOptions cfOptions = cfName.getDescriptor().getOptions()) {
Comment thread
leekeiabstraction marked this conversation as resolved.
outputLevel = Math.min(level + 1, cfOptions.numLevels() - 1);
}
LOG.debug(
"Manually compacting {} files from level {} to {}: {}",
files.size(),
Expand Down