[FLINK-40195] helm: make webhook certificate secret name configurable#1163
Open
applike-ss wants to merge 1 commit into
Open
[FLINK-40195] helm: make webhook certificate secret name configurable#1163applike-ss wants to merge 1 commit into
applike-ss wants to merge 1 commit into
Conversation
applike-ss
marked this pull request as ready for review
July 20, 2026 06:11
applike-ss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the webhook certificate Secret name configurable via
webhook.certSecretNameinvalues.yaml.The previous hardcoded value
webhook-server-certcaused collisions when multiple operator instances (or other operators also hardcoding this secret name) were installed in the same namespace or when external cert management required a specific secret name.Changes
webhook.certSecretNamevalue (optional, defaults to<release-name>-webhook-server-cert)flink-operator.webhookCertSecretNamehelper in_helpers.tplcertificate.yamlanddeployment.yamlto use the helperWhat was tested
helm templatewith default values → produces<release-name>-webhook-server-certhelm template --set webhook.certSecretName=custom→ producescustom