Move setLastReconciledSpec to after successful transition start#1076
Closed
Yanisdje wants to merge 10 commits into
Closed
Move setLastReconciledSpec to after successful transition start#1076Yanisdje wants to merge 10 commits into
Yanisdje wants to merge 10 commits into
Conversation
Move setLastReconciledSpec to after successful transition start
Revert "Move setLastReconciledSpec to after successful transition start"
Clear stale savepointTriggerId on B/G transition abort
Yanisdje
marked this pull request as draft
March 20, 2026 18:05
Made-with: Cursor
2 tasks
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the last reconciled spec on the flink b/g deployment shows an updated spec even when the update failed.
Summary
setLastReconciledSpec()to afterstartTransition()andstartSavepointRedeployTransition()succeed, so it's not stamped if the transition failslastReconciledSpecwas set before the transition call — if the transition failed or was later aborted,lastReconciledSpecreflected the new spec while the active child still ran the old one. Subsequent deploys would see no diff and fall into PATCH_CHILD (in-place upgrade) instead of a proper B/G transitionverifySavepointFetchFailureRecoveryconfirminglastReconciledSpecdoes not contain the failed spec changeContext
Slack thread: https://shopify.enterprise.slack.com/archives/C0ALAR1TLP8
Test plan
verifySavepointFetchFailureRecoverypasses with new assertionFixes Shopify/streaming-compute#882