-
Notifications
You must be signed in to change notification settings - Fork 95
[FLINK-33653][runtime] Introduce a benchmark for balanced tasks scheduling. #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RocMarshal
wants to merge
5
commits into
apache:master
Choose a base branch
from
RocMarshal:FLINK-33653
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1171f0a
[FLINK-33653][runtime] Introduce a throughput benchmark for streaming…
RocMarshal 18b5b6c
[FLINK-33653][runtime] Introduce a benchmark for default scheduler sl…
RocMarshal 8795609
[FLINK-33653][runtime] Introduce a benchmark for adaptive scheduler s…
RocMarshal 703253c
[FLINK-33653][runtime] Introduce a benchmark for adaptive scheduler s…
RocMarshal 8e064a5
[FLINK-33653][runtime] Introduce a benchmark for default scheduler sl…
RocMarshal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
163 changes: 163 additions & 0 deletions
163
...er/benchmark/scheduling/slot/matching/resolver/SlotMatchingResolverBenchmarkExecutor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.scheduler.benchmark.scheduling.slot.matching.resolver; | ||
|
|
||
| import org.apache.flink.configuration.TaskManagerOptions.TaskManagerLoadBalanceMode; | ||
| import org.apache.flink.runtime.clusterframework.types.AllocationID; | ||
| import org.apache.flink.runtime.clusterframework.types.ResourceID; | ||
| import org.apache.flink.runtime.clusterframework.types.ResourceProfile; | ||
| import org.apache.flink.runtime.jobgraph.JobVertexID; | ||
| import org.apache.flink.runtime.jobmanager.scheduler.SlotSharingGroup; | ||
| import org.apache.flink.runtime.jobmaster.slotpool.PhysicalSlot; | ||
| import org.apache.flink.runtime.scheduler.adaptive.allocator.SimpleSlotMatchingResolver; | ||
| import org.apache.flink.runtime.scheduler.adaptive.allocator.SlotMatchingResolver; | ||
| import org.apache.flink.runtime.scheduler.adaptive.allocator.SlotSharingSlotAllocator.ExecutionSlotSharingGroup; | ||
| import org.apache.flink.runtime.scheduler.adaptive.allocator.SlotsBalancedSlotMatchingResolver; | ||
| import org.apache.flink.runtime.scheduler.adaptive.allocator.TasksBalancedSlotMatchingResolver; | ||
| import org.apache.flink.runtime.scheduler.adaptive.allocator.TestingSlot; | ||
| import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID; | ||
| import org.apache.flink.runtime.taskmanager.TaskManagerLocation; | ||
| import org.apache.flink.scheduler.benchmark.SchedulerBenchmarkExecutorBase; | ||
|
|
||
| import org.openjdk.jmh.annotations.Benchmark; | ||
| import org.openjdk.jmh.annotations.BenchmarkMode; | ||
| import org.openjdk.jmh.annotations.Level; | ||
| import org.openjdk.jmh.annotations.Mode; | ||
| import org.openjdk.jmh.annotations.Param; | ||
| import org.openjdk.jmh.annotations.Setup; | ||
| import org.openjdk.jmh.infra.Blackhole; | ||
| import org.openjdk.jmh.runner.RunnerException; | ||
|
|
||
| import java.net.InetAddress; | ||
| import java.net.UnknownHostException; | ||
| import java.util.ArrayList; | ||
| import java.util.Collection; | ||
| import java.util.HashSet; | ||
| import java.util.List; | ||
| import java.util.Set; | ||
|
|
||
| /** The executor to drive {@link SlotMatchingResolver}. */ | ||
| public class SlotMatchingResolverBenchmarkExecutor extends SchedulerBenchmarkExecutorBase { | ||
|
|
||
| /** | ||
| * We set the number of slots is very smaller than the number of task managers to simulate the | ||
| * production environment to the greatest extent possible. | ||
| */ | ||
| public static final int SLOTS_PER_TASKS_MANAGER = 8; | ||
|
|
||
| public static final int TASK_MANAGERS = 128; | ||
|
|
||
| private static final int requestedSlotSharingGroups = 3; | ||
| private static final List<SlotSharingGroup> slotSharingGroups = new ArrayList<>(); | ||
| private static final Collection<ExecutionSlotSharingGroup> requestGroups = new ArrayList<>(); | ||
| private static final Collection<PhysicalSlot> slots = new ArrayList<>(); | ||
|
|
||
| static { | ||
| // For ResourceProfile.UNKNOWN. | ||
| slotSharingGroups.add(new SlotSharingGroup()); | ||
| // For other resource profiles. | ||
| for (int i = 1; i < requestedSlotSharingGroups; i++) { | ||
| SlotSharingGroup sharingGroup = new SlotSharingGroup(); | ||
| sharingGroup.setResourceProfile(newGrainfinedResourceProfile(i)); | ||
| slotSharingGroups.add(sharingGroup); | ||
| } | ||
| // For requested groups and slots. | ||
| for (int tmIndex = 0; tmIndex < TASK_MANAGERS; tmIndex++) { | ||
|
|
||
| TaskManagerLocation tml = getTaskManagerLocation(tmIndex + 1); | ||
|
|
||
| for (int slotIndex = 0; slotIndex < SLOTS_PER_TASKS_MANAGER; slotIndex++) { | ||
| ResourceProfile profile = newGrainfinedResourceProfile(slotIndex); | ||
|
|
||
| slots.add(new TestingSlot(new AllocationID(), profile, tml)); | ||
| requestGroups.add(getExecutionSlotSharingGroup(slotIndex + 1, slotIndex)); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private static ExecutionSlotSharingGroup getExecutionSlotSharingGroup( | ||
| int loading, int slotIndex) { | ||
| Set<ExecutionVertexID> executionVertexIDSet = new HashSet<>(); | ||
| JobVertexID jobVertexID = new JobVertexID(); | ||
| for (int i = 0; i < loading; i++) { | ||
| executionVertexIDSet.add(new ExecutionVertexID(jobVertexID, i)); | ||
| } | ||
| return new ExecutionSlotSharingGroup( | ||
| slotSharingGroups.get(slotIndex % 3), executionVertexIDSet); | ||
| } | ||
|
|
||
| public static TaskManagerLocation getTaskManagerLocation(int dataPort) { | ||
| try { | ||
| InetAddress inetAddress = InetAddress.getByName("1.2.3.4"); | ||
| return new TaskManagerLocation(ResourceID.generate(), inetAddress, dataPort); | ||
| } catch (UnknownHostException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
|
|
||
| public static ResourceProfile newGrainfinedResourceProfile(int slotIndex) { | ||
| return ResourceProfile.newBuilder() | ||
| .setCpuCores(slotIndex % 2 == 0 ? 1 : 2) | ||
| .setTaskHeapMemoryMB(100) | ||
| .setTaskOffHeapMemoryMB(100) | ||
| .setManagedMemoryMB(100) | ||
| .build(); | ||
| } | ||
|
|
||
| @Param({"NONE", "SLOTS", "TASKS"}) | ||
| private TaskManagerLoadBalanceMode taskManagerLoadBalanceMode; | ||
|
|
||
| private SlotMatchingResolver slotMatchingResolver; | ||
|
|
||
| public static void main(String[] args) throws RunnerException { | ||
| runBenchmark(SlotMatchingResolverBenchmarkExecutor.class); | ||
| } | ||
|
|
||
| @Setup(Level.Trial) | ||
| public void setup() throws Exception { | ||
| slotMatchingResolver = getSlotMatchingResolver(); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| } | ||
|
|
||
| @Benchmark | ||
| @BenchmarkMode(Mode.SingleShotTime) | ||
| public void runSlotsMatching(Blackhole blackhole) { | ||
| blackhole.consume( | ||
| slotMatchingResolver.matchSlotSharingGroupWithSlots(requestGroups, slots)); | ||
| } | ||
|
|
||
| private SlotMatchingResolver getSlotMatchingResolver() { | ||
| switch (taskManagerLoadBalanceMode) { | ||
| case NONE: | ||
| this.slotMatchingResolver = SimpleSlotMatchingResolver.INSTANCE; | ||
| break; | ||
| case SLOTS: | ||
| this.slotMatchingResolver = SlotsBalancedSlotMatchingResolver.INSTANCE; | ||
| break; | ||
| case TASKS: | ||
| this.slotMatchingResolver = TasksBalancedSlotMatchingResolver.INSTANCE; | ||
| break; | ||
| default: | ||
| throw new UnsupportedOperationException( | ||
| String.format( | ||
| "Unsupported task manager load balance mode '%s' in %s", | ||
| taskManagerLoadBalanceMode, getClass().getName())); | ||
| } | ||
| return slotMatchingResolver; | ||
| } | ||
| } | ||
122 changes: 122 additions & 0 deletions
122
...hmark/scheduling/slot/matching/strategy/RequestSlotMatchingStrategyBenchmarkExecutor.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.scheduler.benchmark.scheduling.slot.matching.strategy; | ||
|
|
||
| import org.apache.flink.configuration.TaskManagerOptions.TaskManagerLoadBalanceMode; | ||
| import org.apache.flink.runtime.clusterframework.types.AllocationID; | ||
| import org.apache.flink.runtime.clusterframework.types.ResourceProfile; | ||
| import org.apache.flink.runtime.jobmaster.SlotRequestId; | ||
| import org.apache.flink.runtime.jobmaster.slotpool.PendingRequest; | ||
| import org.apache.flink.runtime.jobmaster.slotpool.PhysicalSlot; | ||
| import org.apache.flink.runtime.jobmaster.slotpool.RequestSlotMatchingStrategy; | ||
| import org.apache.flink.runtime.jobmaster.slotpool.SimpleRequestSlotMatchingStrategy; | ||
| import org.apache.flink.runtime.jobmaster.slotpool.TasksBalancedRequestSlotMatchingStrategy; | ||
| import org.apache.flink.runtime.scheduler.adaptive.allocator.TestingSlot; | ||
| import org.apache.flink.runtime.scheduler.loading.DefaultLoadingWeight; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It has been renamed in https://github.com/apache/flink/pull/27333/changesgg so it probably should be: |
||
| import org.apache.flink.runtime.taskmanager.TaskManagerLocation; | ||
| import org.apache.flink.scheduler.benchmark.SchedulerBenchmarkExecutorBase; | ||
|
|
||
| import org.openjdk.jmh.annotations.Benchmark; | ||
| import org.openjdk.jmh.annotations.BenchmarkMode; | ||
| import org.openjdk.jmh.annotations.Level; | ||
| import org.openjdk.jmh.annotations.Mode; | ||
| import org.openjdk.jmh.annotations.Param; | ||
| import org.openjdk.jmh.annotations.Setup; | ||
| import org.openjdk.jmh.infra.Blackhole; | ||
| import org.openjdk.jmh.runner.RunnerException; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Collection; | ||
| import java.util.Collections; | ||
| import java.util.HashMap; | ||
|
|
||
| import static org.apache.flink.scheduler.benchmark.scheduling.slot.matching.resolver.SlotMatchingResolverBenchmarkExecutor.SLOTS_PER_TASKS_MANAGER; | ||
| import static org.apache.flink.scheduler.benchmark.scheduling.slot.matching.resolver.SlotMatchingResolverBenchmarkExecutor.TASK_MANAGERS; | ||
| import static org.apache.flink.scheduler.benchmark.scheduling.slot.matching.resolver.SlotMatchingResolverBenchmarkExecutor.getTaskManagerLocation; | ||
| import static org.apache.flink.scheduler.benchmark.scheduling.slot.matching.resolver.SlotMatchingResolverBenchmarkExecutor.newGrainfinedResourceProfile; | ||
|
|
||
| /** The executor to drive {@link RequestSlotMatchingStrategy}. */ | ||
| public class RequestSlotMatchingStrategyBenchmarkExecutor extends SchedulerBenchmarkExecutorBase { | ||
|
|
||
| private static final Collection<PhysicalSlot> slots = new ArrayList<>(); | ||
| private static final Collection<PendingRequest> slotRequests = new ArrayList<>(); | ||
|
|
||
| static { | ||
| // For requested groups and slots. | ||
| for (int tmIndex = 0; tmIndex < TASK_MANAGERS; tmIndex++) { | ||
|
|
||
| TaskManagerLocation tml = getTaskManagerLocation(tmIndex + 1); | ||
|
|
||
| for (int slotIndex = 0; slotIndex < SLOTS_PER_TASKS_MANAGER; slotIndex++) { | ||
| ResourceProfile profile = newGrainfinedResourceProfile(slotIndex); | ||
|
|
||
| slots.add(new TestingSlot(new AllocationID(), profile, tml)); | ||
| slotRequests.add(getPendingRequest(slotIndex + 1, slotIndex)); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private static PendingRequest getPendingRequest(float loading, int slotIndex) { | ||
| return PendingRequest.createNormalRequest( | ||
| new SlotRequestId(), | ||
| newGrainfinedResourceProfile(slotIndex), | ||
| new DefaultLoadingWeight(loading), | ||
| Collections.emptyList()); | ||
| } | ||
|
|
||
| @Param({"NONE", "TASKS"}) | ||
| private TaskManagerLoadBalanceMode taskManagerLoadBalanceMode; | ||
|
|
||
| private RequestSlotMatchingStrategy requestSlotMatchingStrategy; | ||
|
|
||
| public static void main(String[] args) throws RunnerException { | ||
| runBenchmark(RequestSlotMatchingStrategyBenchmarkExecutor.class); | ||
| } | ||
|
|
||
| @Setup(Level.Trial) | ||
| public void setup() throws Exception { | ||
| requestSlotMatchingStrategy = getRequestSlotMatchingStrategy(); | ||
| } | ||
|
|
||
| @Benchmark | ||
| @BenchmarkMode(Mode.SingleShotTime) | ||
| public void runSlotsMatching(Blackhole blackhole) { | ||
| blackhole.consume( | ||
| requestSlotMatchingStrategy.matchRequestsAndSlots( | ||
| slots, slotRequests, new HashMap<>())); | ||
| } | ||
|
|
||
| private RequestSlotMatchingStrategy getRequestSlotMatchingStrategy() { | ||
| switch (taskManagerLoadBalanceMode) { | ||
| case TASKS: | ||
| this.requestSlotMatchingStrategy = | ||
| TasksBalancedRequestSlotMatchingStrategy.INSTANCE; | ||
| break; | ||
| case NONE: | ||
| this.requestSlotMatchingStrategy = SimpleRequestSlotMatchingStrategy.INSTANCE; | ||
| break; | ||
| default: | ||
| throw new UnsupportedOperationException( | ||
| String.format( | ||
| "Unsupported task manager load balance mode '%s' in %s", | ||
| taskManagerLoadBalanceMode, getClass().getName())); | ||
| } | ||
| return requestSlotMatchingStrategy; | ||
| } | ||
| } | ||
98 changes: 98 additions & 0 deletions
98
...nk/scheduler/benchmark/scheduling/slot/sharing/resolver/SlotSharingResolverBenchmark.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.scheduler.benchmark.scheduling.slot.sharing.resolver; | ||
|
|
||
| import org.apache.flink.configuration.TaskManagerOptions.TaskManagerLoadBalanceMode; | ||
| import org.apache.flink.runtime.JobException; | ||
| import org.apache.flink.runtime.client.JobExecutionException; | ||
| import org.apache.flink.runtime.executiongraph.AccessExecutionJobVertex; | ||
| import org.apache.flink.runtime.executiongraph.ExecutionGraph; | ||
| import org.apache.flink.runtime.executiongraph.TestingDefaultExecutionGraphBuilder; | ||
| import org.apache.flink.runtime.jobgraph.JobGraph; | ||
| import org.apache.flink.runtime.jobgraph.JobGraphBuilder; | ||
| import org.apache.flink.runtime.jobgraph.JobVertex; | ||
| import org.apache.flink.runtime.scheduler.VertexParallelismStore; | ||
| import org.apache.flink.runtime.scheduler.adaptive.JobGraphJobInformation; | ||
| import org.apache.flink.runtime.scheduler.adaptive.allocator.DefaultSlotSharingResolver; | ||
| import org.apache.flink.runtime.scheduler.adaptive.allocator.JobInformation; | ||
| import org.apache.flink.runtime.scheduler.adaptive.allocator.SlotSharingResolver; | ||
| import org.apache.flink.runtime.scheduler.adaptive.allocator.SlotSharingSlotAllocator; | ||
| import org.apache.flink.runtime.scheduler.adaptive.allocator.TaskBalancedSlotSharingResolver; | ||
| import org.apache.flink.runtime.scheduler.adaptive.allocator.VertexParallelism; | ||
| import org.apache.flink.runtime.testutils.DirectScheduledExecutorService; | ||
|
|
||
| import java.util.Collection; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| import static org.apache.flink.runtime.scheduler.SchedulerBase.computeVertexParallelismStore; | ||
|
|
||
| /** | ||
| * The benchmark of initializing {@link | ||
| * org.apache.flink.runtime.scheduler.adaptive.allocator.SlotSharingResolver}. | ||
| */ | ||
| public class SlotSharingResolverBenchmark { | ||
|
|
||
| private final JobInformation jobInformation; | ||
| private final VertexParallelism vertexParallelism; | ||
| private final TaskManagerLoadBalanceMode taskManagerLoadBalanceMode; | ||
|
|
||
| public SlotSharingResolverBenchmark( | ||
| TaskManagerLoadBalanceMode taskManagerLoadBalanceMode, Collection<JobVertex> vertices) { | ||
| this.taskManagerLoadBalanceMode = taskManagerLoadBalanceMode; | ||
| final JobGraph jobGraph = | ||
| JobGraphBuilder.newStreamingJobGraphBuilder().addJobVertices(vertices).build(); | ||
| try { | ||
| ExecutionGraph executionGraph = | ||
| TestingDefaultExecutionGraphBuilder.newBuilder() | ||
| .setJobGraph(jobGraph) | ||
| .build(new DirectScheduledExecutorService()); | ||
| VertexParallelismStore vertexParallelismStore = computeVertexParallelismStore(jobGraph); | ||
| this.jobInformation = new JobGraphJobInformation(jobGraph, vertexParallelismStore); | ||
| this.vertexParallelism = | ||
| new VertexParallelism( | ||
| executionGraph.getAllVertices().values().stream() | ||
| .collect( | ||
| Collectors.toMap( | ||
| AccessExecutionJobVertex::getJobVertexId, | ||
| AccessExecutionJobVertex::getParallelism))); | ||
| } catch (JobException | JobExecutionException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
|
|
||
| public Collection<SlotSharingSlotAllocator.ExecutionSlotSharingGroup> | ||
| invokeSlotSharingResolver() { | ||
| SlotSharingResolver slotSharingResolver = createSlotSharingResolver(); | ||
| return slotSharingResolver.getExecutionSlotSharingGroups(jobInformation, vertexParallelism); | ||
| } | ||
|
|
||
| private SlotSharingResolver createSlotSharingResolver() { | ||
| switch (taskManagerLoadBalanceMode) { | ||
| case NONE: | ||
| return DefaultSlotSharingResolver.INSTANCE; | ||
| case TASKS: | ||
| return TaskBalancedSlotSharingResolver.INSTANCE; | ||
| default: | ||
| throw new UnsupportedOperationException( | ||
| String.format( | ||
| "Unsupported task manager load balance mode '%s' in %s", | ||
| taskManagerLoadBalanceMode, getClass().getName())); | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type:
newfineGrainedResourceProfile