chore(OrderedFinalAggregateStream): refactor to async generator - #24008
chore(OrderedFinalAggregateStream): refactor to async generator#24008rluvaton wants to merge 6 commits into
OrderedFinalAggregateStream): refactor to async generator#24008Conversation
OrderedFinalAggregateStream): refactor to async generator
|
@2010YOUY01 can you please review? |
|
run benchmark tpcds |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing move-ordered-final-stream-to-generators (478a772) to 541caab (merge-base) diff using: tpcds File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24008 +/- ##
==========================================
+ Coverage 80.84% 80.85% +0.01%
==========================================
Files 1096 1098 +2
Lines 373936 374087 +151
Branches 373936 374087 +151
==========================================
+ Hits 302313 302486 +173
+ Misses 53584 53548 -36
- Partials 18039 18053 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Which issue does this PR close?
Related to:
Rationale for this change
Avoid a lot of states that exists only for
Pollmechanism, and cleanup the codeWhat changes are included in this PR?
refactor code to use async generators
Are these changes tested?
Existing tests
Are there any user-facing changes?
No