refactor: move lambda variable scope into Physical Planning Context - #23989
Open
sweb wants to merge 1 commit into
Open
refactor: move lambda variable scope into Physical Planning Context#23989sweb wants to merge 1 commit into
sweb wants to merge 1 commit into
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23989 +/- ##
==========================================
- Coverage 80.75% 80.75% -0.01%
==========================================
Files 1096 1096
Lines 373588 373604 +16
Branches 373588 373604 +16
==========================================
+ Hits 301687 301695 +8
- Misses 53898 53901 +3
- Partials 18003 18008 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sweb
force-pushed
the
refactor/move-lambda-eval
branch
from
July 30, 2026 08:28
0bab196 to
3b38dfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This is a clean up following #23649
What changes are included in this PR?
Moves the lambda-variable scope state out of
ExecutionPropsand intoPhysicalPlanningContext, following the same pattern as the scalar-subquery state in refactor: passPhysicalPlanningContextexplicitly through planner traits #23649.Puts
PhysicalPlanningContext::indexesbehind anArcso the new per-lambda-body clone doesn't deep-copy the subquery index map.PhysicalPlanningContext::new's signature is unchanged.Are these changes tested?
lambda_variables_shadow_outer_scopeunit test inphysical_planning_context.rscoverswith_qualified_lambda_variables/lambda_variable_qualifierdirectly, including an inner lambda shadowing an outer parameter name.Are there any user-facing changes?
this is a breaking change for lib users.