Skip to content

minor(test): strengthen sort-merge join spilling coverage - #23988

Open
buraksenn wants to merge 2 commits into
apache:mainfrom
buraksenn:smj-spill-test-coverage
Open

minor(test): strengthen sort-merge join spilling coverage#23988
buraksenn wants to merge 2 commits into
apache:mainfrom
buraksenn:smj-spill-test-coverage

Conversation

@buraksenn

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Contuining the work after #23947. Now SortMergeJoinExec supports spilling under memory pressure, but existing tests do not consistently assert that spilling occurs.

What changes are included in this PR?

Adds spill fuzz coverage, constrained-memory stress tests for materializing joins, and process-isolated memory-limit validation.

Are these changes tested?

test only change and it can be tested via:


cargo test -p datafusion --test fuzz --features extended_tests spill
cargo test -p datafusion --test core_integration --features extended_tests smj_

Are there any user-facing changes?

no test only change

@github-actions github-actions Bot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) labels Jul 30, 2026
@buraksenn
buraksenn force-pushed the smj-spill-test-coverage branch from 500ec34 to f45a5cd Compare July 30, 2026 06:45
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.75%. Comparing base (994fc81) to head (f45a5cd).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23988      +/-   ##
==========================================
+ Coverage   80.69%   80.75%   +0.05%     
==========================================
  Files        1095     1096       +1     
  Lines      372626   373588     +962     
  Branches   372626   373588     +962     
==========================================
+ Hits       300700   301687     +987     
+ Misses      53978    53897      -81     
- Partials    17948    18004      +56     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants